Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fake timers to prevent voip unit tests failing sporadically #33414

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Oct 1, 2024

Proposed changes (including videos or screenshots)

Jest.useFakeTimers() was added to guarantee the UI information for VoipOngoingPopup is consistent. This change prevents the test from failing sporadically if the call timer changes while the test is running.

Screenshot 2024-10-02 at 10 46 10

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Oct 1, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 1, 2024

⚠️ No Changeset found

Latest commit: 8e5513b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 1, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-02 16:16 UTC

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.57%. Comparing base (cfb6912) to head (8e5513b).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33414   +/-   ##
========================================
  Coverage    58.57%   58.57%           
========================================
  Files         2737     2737           
  Lines        65763    65763           
  Branches     14826    14826           
========================================
  Hits         38521    38521           
  Misses       24463    24463           
  Partials      2779     2779           
Flag Coverage Δ
unit 75.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleksandernsilva aleksandernsilva marked this pull request as ready for review October 1, 2024 22:09
@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Oct 2, 2024
@aleksandernsilva aleksandernsilva added the stat: ready to merge PR tested and approved waiting for merge label Oct 2, 2024
@ggazzo ggazzo added this to the 6.14 milestone Oct 2, 2024
@kodiakhq kodiakhq bot merged commit f2844aa into develop Oct 2, 2024
45 checks passed
@kodiakhq kodiakhq bot deleted the test/voip-flaky-unit-test branch October 2, 2024 16:16
@ggazzo ggazzo modified the milestones: 6.14, 7.0 Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants