Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fake timers to prevent voip unit tests failing sporadically #33414

Merged
merged 2 commits into from
Oct 2, 2024
Merged

test: fake timers to prevent voip unit tests failing sporadically #33414

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9ef25a
test: fake timers to prevent voip unit tests failing sporadically
aleksandernsilva Oct 1, 2024
8e5513b
Merge branch 'develop' into test/voip-flaky-unit-test
kodiakhq[bot] Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 61 additions & 51 deletions packages/ui-voip/src/components/VoipPopup/views/VoipOngoingView.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,55 +8,65 @@ const wrapper = mockAppRoot().withEndpoint('GET', '/v1/voip-freeswitch.extension

const ongoingSession = createMockVoipOngoingSession();

it('should properly render ongoing view', async () => {
render(<VoipOngoingView session={ongoingSession} />, { wrapper: wrapper.build(), legacyRoot: true });

expect(screen.getByText('00:00')).toBeInTheDocument();
expect(screen.getByRole('button', { name: /Device_settings/ })).toBeInTheDocument();
expect(await screen.findByText('Administrator')).toBeInTheDocument();
expect(screen.queryByText('On_Hold')).not.toBeInTheDocument();
expect(screen.queryByText('Muted')).not.toBeInTheDocument();
});

it('should display on hold and muted', () => {
ongoingSession.isMuted = true;
ongoingSession.isHeld = true;

render(<VoipOngoingView session={ongoingSession} />, { wrapper: wrapper.build(), legacyRoot: true });

expect(screen.getByText('On_Hold')).toBeInTheDocument();
expect(screen.getByText('Muted')).toBeInTheDocument();

ongoingSession.isMuted = false;
ongoingSession.isHeld = false;
});

it('should only enable ongoing call actions', () => {
render(<VoipOngoingView session={ongoingSession} />, { wrapper: wrapper.build(), legacyRoot: true });

expect(within(screen.getByTestId('vc-popup-footer')).queryAllByRole('button')).toHaveLength(5);
expect(screen.getByRole('button', { name: 'Turn_off_microphone' })).toBeEnabled();
expect(screen.getByRole('button', { name: 'Hold' })).toBeEnabled();
expect(screen.getByRole('button', { name: 'Open_Dialpad' })).toBeEnabled();
expect(screen.getByRole('button', { name: 'Transfer_call' })).toBeEnabled();
expect(screen.getByRole('button', { name: 'End_call' })).toBeEnabled();
});

it('should properly interact with the voice call session', () => {
render(<VoipOngoingView session={ongoingSession} />, { wrapper: wrapper.build(), legacyRoot: true });

screen.getByRole('button', { name: 'Turn_off_microphone' }).click();
expect(ongoingSession.mute).toHaveBeenCalled();

screen.getByRole('button', { name: 'Hold' }).click();
expect(ongoingSession.hold).toHaveBeenCalled();

screen.getByRole('button', { name: 'Open_Dialpad' }).click();
screen.getByTestId('dial-pad-button-1').click();
expect(screen.getByRole('textbox', { name: 'Phone_number' })).toHaveValue('1');
expect(ongoingSession.dtmf).toHaveBeenCalledWith('1');

expect(screen.getByRole('button', { name: 'End_call' })).toBeEnabled();
screen.getByRole('button', { name: 'End_call' }).click();
expect(ongoingSession.end).toHaveBeenCalled();
describe('VoipOngoingView', () => {
beforeEach(() => {
jest.useFakeTimers();
});

afterEach(() => {
jest.clearAllTimers();
});

it('should properly render ongoing view', async () => {
render(<VoipOngoingView session={ongoingSession} />, { wrapper: wrapper.build(), legacyRoot: true });

expect(screen.getByText('00:00')).toBeInTheDocument();
expect(screen.getByRole('button', { name: /Device_settings/ })).toBeInTheDocument();
expect(await screen.findByText('Administrator')).toBeInTheDocument();
expect(screen.queryByText('On_Hold')).not.toBeInTheDocument();
expect(screen.queryByText('Muted')).not.toBeInTheDocument();
});

it('should display on hold and muted', () => {
ongoingSession.isMuted = true;
ongoingSession.isHeld = true;

render(<VoipOngoingView session={ongoingSession} />, { wrapper: wrapper.build(), legacyRoot: true });

expect(screen.getByText('On_Hold')).toBeInTheDocument();
expect(screen.getByText('Muted')).toBeInTheDocument();

ongoingSession.isMuted = false;
ongoingSession.isHeld = false;
});

it('should only enable ongoing call actions', () => {
render(<VoipOngoingView session={ongoingSession} />, { wrapper: wrapper.build(), legacyRoot: true });

expect(within(screen.getByTestId('vc-popup-footer')).queryAllByRole('button')).toHaveLength(5);
expect(screen.getByRole('button', { name: 'Turn_off_microphone' })).toBeEnabled();
expect(screen.getByRole('button', { name: 'Hold' })).toBeEnabled();
expect(screen.getByRole('button', { name: 'Open_Dialpad' })).toBeEnabled();
expect(screen.getByRole('button', { name: 'Transfer_call' })).toBeEnabled();
expect(screen.getByRole('button', { name: 'End_call' })).toBeEnabled();
});

it('should properly interact with the voice call session', () => {
render(<VoipOngoingView session={ongoingSession} />, { wrapper: wrapper.build(), legacyRoot: true });

screen.getByRole('button', { name: 'Turn_off_microphone' }).click();
expect(ongoingSession.mute).toHaveBeenCalled();

screen.getByRole('button', { name: 'Hold' }).click();
expect(ongoingSession.hold).toHaveBeenCalled();

screen.getByRole('button', { name: 'Open_Dialpad' }).click();
screen.getByTestId('dial-pad-button-1').click();
expect(screen.getByRole('textbox', { name: 'Phone_number' })).toHaveValue('1');
expect(ongoingSession.dtmf).toHaveBeenCalledWith('1');

expect(screen.getByRole('button', { name: 'End_call' })).toBeEnabled();
screen.getByRole('button', { name: 'End_call' }).click();
expect(ongoingSession.end).toHaveBeenCalled();
});
});
Loading