-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: deno runtime controller not handling undefined child process reference correctly #33494
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 5f6ad7e The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33494 +/- ##
========================================
Coverage 58.58% 58.58%
========================================
Files 2737 2737
Lines 65677 65677
Branches 14824 14824
========================================
Hits 38478 38478
Misses 24420 24420
Partials 2779 2779
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
DenoRuntimeSubprocessController
was not handling correctly some cases where the child process reference could be undefined. This happens in cases where the app has been restarted 3 times and the engine will not restart it further.Issue(s)
CONN-355
Steps to test or reproduce
Further comments