Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deno runtime controller not handling undefined child process reference correctly #33494

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

d-gubert
Copy link
Member

@d-gubert d-gubert commented Oct 8, 2024

Proposed changes (including videos or screenshots)

DenoRuntimeSubprocessController was not handling correctly some cases where the child process reference could be undefined. This happens in cases where the app has been restarted 3 times and the engine will not restart it further.

Issue(s)

CONN-355

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Oct 8, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 8, 2024

🦋 Changeset detected

Latest commit: 5f6ad7e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@rocket.chat/apps-engine Patch
@rocket.chat/meteor Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@d-gubert d-gubert added this to the 6.14 milestone Oct 8, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-09 15:50 UTC

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.58%. Comparing base (d9fe5bb) to head (5f6ad7e).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33494   +/-   ##
========================================
  Coverage    58.58%   58.58%           
========================================
  Files         2737     2737           
  Lines        65677    65677           
  Branches     14824    14824           
========================================
  Hits         38478    38478           
  Misses       24420    24420           
  Partials      2779     2779           
Flag Coverage Δ
unit 75.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@d-gubert d-gubert marked this pull request as ready for review October 8, 2024 15:43
@d-gubert d-gubert requested a review from a team as a code owner October 8, 2024 15:43
@d-gubert d-gubert added the stat: QA assured Means it has been tested and approved by a company insider label Oct 8, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 8, 2024
@kodiakhq kodiakhq bot merged commit 5f9826b into develop Oct 9, 2024
50 checks passed
@kodiakhq kodiakhq bot deleted the fix/deno-exit-code-error branch October 9, 2024 15:50
@ggazzo ggazzo modified the milestones: 6.14, 7.0 Oct 17, 2024
d-gubert added a commit to RocketChat/Rocket.Chat.Apps-engine that referenced this pull request Nov 10, 2024
d-gubert added a commit to RocketChat/Rocket.Chat.Apps-engine that referenced this pull request Dec 6, 2024
d-gubert added a commit to RocketChat/Rocket.Chat.Apps-engine that referenced this pull request Dec 6, 2024
d-gubert added a commit to RocketChat/Rocket.Chat.Apps-engine that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants