Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Apps-engine fixes #34145

Open
wants to merge 2 commits into
base: release-6.12.4
Choose a base branch
from

Conversation

d-gubert
Copy link
Member

@d-gubert d-gubert commented Dec 9, 2024

Copy link
Contributor

dionisio-bot bot commented Dec 9, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 6.12.4, but it targets 6.12.3

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Dec 9, 2024

🦋 Changeset detected

Latest commit: 918eb9e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@rocket.chat/omnichannel-services Patch
rocketchat-services Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/authorization-service Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/presence-service Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/instance-status Patch
@rocket.chat/account-service Patch
@rocket.chat/message-parser Patch
@rocket.chat/api-client Patch
@rocket.chat/ddp-client Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/core-services Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/core-typings Patch
@rocket.chat/peggy-loader Patch
@rocket.chat/rest-typings Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/queue-worker Patch
@rocket.chat/presence Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/license Patch
@rocket.chat/gazzodown Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/livechat Patch
@rocket.chat/models Patch
@rocket.chat/apps Patch
@rocket.chat/cron Patch
@rocket.chat/meteor Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@d-gubert d-gubert added this to the 6.12.4 milestone Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-6.12.4@24c1b1f). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-6.12.4   #34145   +/-   ##
=================================================
  Coverage                  ?   58.25%           
=================================================
  Files                     ?     2682           
  Lines                     ?    65000           
  Branches                  ?    14600           
=================================================
  Hits                      ?    37865           
  Misses                    ?    24372           
  Partials                  ?     2763           
Flag Coverage Δ
unit 75.62% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@d-gubert d-gubert marked this pull request as ready for review December 9, 2024 16:04
@d-gubert d-gubert requested review from a team as code owners December 9, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant