-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: E2EE room key reset modal #33503
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 502616b The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
f1a821b
to
fd881cd
Compare
2c114c8
to
ac2dae4
Compare
dd6caeb
to
2910905
Compare
f9923c3
to
a5903b1
Compare
apps/meteor/client/views/room/modals/E2EEModals/ResetKeysE2EEModal.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/room/modals/E2EEModals/EnableE2EEModal.tsx
Outdated
Show resolved
Hide resolved
5bbcb1d
to
a5903b1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33503 +/- ##
========================================
Coverage 74.85% 74.85%
========================================
Files 470 470
Lines 20744 20744
Branches 5295 5295
========================================
Hits 15528 15528
Misses 4595 4595
Partials 621 621
Flags with carried forward coverage won't be shown. Click here to find out more. |
74c35e3
to
a5903b1
Compare
44cb522
to
a0e985d
Compare
5015408
to
2435c3b
Compare
5435cb9
to
2872812
Compare
fix: remove duplicated toast error
454e22d
to
415ddca
Compare
Co-authored-by: Kevin Aleman <11577696+KevLehman@users.noreply.github.com>
Proposed changes (including videos or screenshots)
If all the members of a room lose their room E2EE keys, then the content of encrypted messages becomes undecryptable forever, and no member has the ability to send new encrypted messages in the room, even after they reset their private E2EE keys.
Given the nature of E2EE, loosing the access to encrypted content when the user loses their E2E keys is something acceptable in the industry, and the most part of other players operate this way. The problem in our implementation is loosing the ability to send new encrypted messages.
To minimize the number of unnecessary room key resets, we created two flows for disabling E2EE (check designs), and one additional warning for enabling E2EE
1 - User does NOT have room key: A button to reset the room key will be exhibited inside the Disable room encryption modal
2 - User has room key: For this use case, the option to reset the room key will NOT be exhibited, and the Disable Encryption modal text is a bit different
3 - Enabling E2EE: A confirmation modal was created
Issue(s)
Steps to test or reproduce
Further comments
TODO
https://rocketchat.atlassian.net/browse/E2EE2-62