Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: E2EE room key reset modal #33503

Merged
merged 29 commits into from
Oct 18, 2024
Merged

feat: E2EE room key reset modal #33503

merged 29 commits into from
Oct 18, 2024

Conversation

hugocostadev
Copy link
Contributor

@hugocostadev hugocostadev commented Oct 8, 2024

Proposed changes (including videos or screenshots)

If all the members of a room lose their room E2EE keys, then the content of encrypted messages becomes undecryptable forever, and no member has the ability to send new encrypted messages in the room, even after they reset their private E2EE keys.

Given the nature of E2EE, loosing the access to encrypted content when the user loses their E2E keys is something acceptable in the industry, and the most part of other players operate this way. The problem in our implementation is loosing the ability to send new encrypted messages.

To minimize the number of unnecessary room key resets, we created two flows for disabling E2EE (check designs), and one additional warning for enabling E2EE

1 - User does NOT have room key: A button to reset the room key will be exhibited inside the Disable room encryption modal
2 - User has room key: For this use case, the option to reset the room key will NOT be exhibited, and the Disable Encryption modal text is a bit different
3 - Enabling E2EE: A confirmation modal was created

Issue(s)

Steps to test or reproduce

Further comments

TODO

  • Add tests

https://rocketchat.atlassian.net/browse/E2EE2-62

Copy link
Contributor

dionisio-bot bot commented Oct 8, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 8, 2024

🦋 Changeset detected

Latest commit: 502616b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/i18n Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/ui-client Major
@rocket.chat/ui-voip Major
@rocket.chat/uikit-playground Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/core-typings Major
@rocket.chat/rest-typings Major
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 8, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33503/
on branch gh-pages at 2024-10-18 15:59 UTC

@KevLehman KevLehman force-pushed the feat/e2e-key-reset branch 3 times, most recently from f1a821b to fd881cd Compare October 10, 2024 17:04
@hugocostadev hugocostadev force-pushed the feat/e2e-key-reset-modal branch 2 times, most recently from 2c114c8 to ac2dae4 Compare October 10, 2024 20:17
@KevLehman KevLehman force-pushed the feat/e2e-key-reset branch 7 times, most recently from dd6caeb to 2910905 Compare October 11, 2024 21:30
@KevLehman KevLehman force-pushed the feat/e2e-key-reset-modal branch from f9923c3 to a5903b1 Compare October 11, 2024 21:40
@KevLehman KevLehman force-pushed the feat/e2e-key-reset-modal branch from 5bbcb1d to a5903b1 Compare October 14, 2024 15:18
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.85%. Comparing base (4aa731d) to head (502616b).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33503   +/-   ##
========================================
  Coverage    74.85%   74.85%           
========================================
  Files          470      470           
  Lines        20744    20744           
  Branches      5295     5295           
========================================
  Hits         15528    15528           
  Misses        4595     4595           
  Partials       621      621           
Flag Coverage Δ
unit 74.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman force-pushed the feat/e2e-key-reset-modal branch from 74c35e3 to a5903b1 Compare October 14, 2024 15:48
@hugocostadev hugocostadev force-pushed the feat/e2e-key-reset-modal branch 3 times, most recently from 5015408 to 2435c3b Compare October 14, 2024 16:57
Base automatically changed from feat/e2e-key-reset to release-7.0.0 October 14, 2024 21:15
@KevLehman KevLehman force-pushed the feat/e2e-key-reset-modal branch from 5435cb9 to 2872812 Compare October 14, 2024 21:19
@hugocostadev hugocostadev force-pushed the feat/e2e-key-reset-modal branch from 454e22d to 415ddca Compare October 17, 2024 13:28
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Oct 18, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 18, 2024
@kodiakhq kodiakhq bot merged commit 2806cb5 into develop Oct 18, 2024
50 checks passed
@kodiakhq kodiakhq bot deleted the feat/e2e-key-reset-modal branch October 18, 2024 16:46
This was referenced Oct 20, 2024
abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024
Co-authored-by: Kevin Aleman <11577696+KevLehman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants