Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cipher: macros and dev modules #342

Closed
tarcieri opened this issue Oct 15, 2020 · 2 comments
Closed

cipher: macros and dev modules #342

tarcieri opened this issue Oct 15, 2020 · 2 comments
Labels
cipher Block and stream cipher crate

Comments

@tarcieri
Copy link
Member

tarcieri commented Oct 15, 2020

In merging block-cipher and stream-cipher, I copied over their respective dev modules as cipher::block::dev and cipher::stream::dev. However, the macros are exported from the toplevel, and end up looking like this:

https://docs.rs/cipher/0.2.0/cipher/#macros

Screen Shot 2020-10-15 at 3 19 51 PM

I think it'd be good to cleanly disambiguate them. Perhaps we could also merge the dev modules.

@tarcieri
Copy link
Member Author

This was partially addressed in #345, which added a new set of "namespaced" macros and kept the old ones around to avoid making the change breaking:

Screen Shot 2020-10-30 at 9 28 23 AM

I'll leave this issue open as a reminder to remove the deprecated methods in the next release.

@tarcieri
Copy link
Member Author

tarcieri commented Dec 9, 2020

This was fixed in #371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cipher Block and stream cipher crate
Projects
None yet
Development

No branches or pull requests

1 participant