Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cipher: remove generic_array re-exports from block and stream modules #344

Closed
tarcieri opened this issue Oct 16, 2020 · 3 comments
Closed

cipher: remove generic_array re-exports from block and stream modules #344

tarcieri opened this issue Oct 16, 2020 · 3 comments
Labels
cipher Block and stream cipher crate

Comments

@tarcieri
Copy link
Member

The block and stream modules of the cipher crate both re-export generic_array and typenum::consts.

A toplevel re-export was added after the publication of cipher v0.2 in #343.

Before publishing cipher v0.3, we should remove the re-exports from block and stream and require using the toplevel one instead.
@tarcieri tarcieri added the cipher Block and stream cipher crate label Oct 16, 2020
@newpavlov
Copy link
Member

Also it's probably worth to hide the dev module from the block-cipher module. Right now it only re-exports blobby, I think it can be re-exported at the top level of the cipher crate instead.

@tarcieri
Copy link
Member Author

tarcieri commented Oct 16, 2020 •
edited
Loading

@newpavlov yeah, left some other notes about dev module fixups in #342

@tarcieri tarcieri mentioned this issue Dec 9, 2020
Closed
2 tasks
@tarcieri
Copy link
Member Author

tarcieri commented Jan 3, 2021

The block and stream modules are no longer part of the public API at all, so I think it's safe to say this was addressed.

@tarcieri tarcieri closed this as completed Jan 3, 2021
dns2utf8 pushed a commit to dns2utf8/traits that referenced this issue Jan 24, 2023
@dependabot
build(deps): bump actions/checkout from 2 to 3 (RustCrypto#344)
fc62490
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cipher Block and stream cipher crate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tarcieri @newpavlov