Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add icons styles to dependant components #2203

Conversation

InnaAtanasova
Copy link
Contributor

Bring @import "~fundamental-styles/dist/icon"; to all components that rely on icons, such as Buttons, Input-Groups, etc.

@JKMarkowski
Copy link
Contributor

Hi @InnaAtanasova, Could you change importing scss files, to just import IconModule into certain modules? Your solution will make our lib bigger, because css code will be repeated in most components.

@droshev droshev deleted the fix/bring-icons-dependant-components branch June 18, 2020 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants