feat: Button in FIori3 | Dialog in Fiori3 | New way of adding Icons #2224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-ngx ready! Built with commit 93e8450 |
salarenko
force-pushed
the
feat/button-dialog-fonts
branch
from
ad366e7 to
0961560
Compare
estelaxu3
approved these changes
Mar 27, 2020
|
|
Issue has been fixed |
rengare
changed the title
|
Looks good to me. |
|
@salarenko conflicts and broken deployment |
Vanessa-Cusmich
approved these changes
Mar 31, 2020
* fix(core) rename modal to dialog * Reworking dialogs header * Refactor dialogs footer * fix(core) Add draggable dialog support * fix(core) Improve dynamic component and dialog service code * fix(core) Introduce custom injector to DynamicComponents | Inject configs to Alert and Notification * fix(core) Create new Dialog Container | Use InjectionTokens with parent assecuration * fix(core) Create resize directive * Update Dialog documentation * fix(core) Add responsive paddings feature to dialog * fix(core) Add CssClassBuilders to Dialog and DialogContainer * fix(core) Update descriptions * fIX(Core) Revert Alert and Notification changes * fix(core) Add unit tests * fix(core) update missing buttons adnotations * fix(core) Update popover example * fix(core) Fix indirect imports * fix(core) Add loading state do Dialog * fix(core) Update tests * fix(core) Update tests * fix(core) Fix alert and notifications * fix(core) Address PR requests * fix(core) Fix resize for IE11
* fix: few fixes in the code and documentation found after tests * small fixes * workaround added to fix missing selector * fix: addresing pr comments
salarenko
force-pushed
the
feat/button-dialog-fonts
branch
from
ad50431 to
471ba18
Compare
…damental-ngx into feat/button-dialog-fonts
JKMarkowski
approved these changes
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
fixes: #2110
fixes: #2127
fixes: #615
Please provide a brief summary of this pull request.
For associated issues and brief summary check:
Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/master/CONTRIBUTING.md
Documentation checklist:
README.mdButton screenshots
Before:
After:
