fix: button fiori3 fixes and documentation improvements #2221

rengare · 2020-03-24T10:43:01Z

Please provide a link to the associated issue.

Please provide a brief summary of this pull request.

The PR brings:

fix for RTL mode for split button
fix for build of documentation for segmented button
deprecated label in button component for properties being deprecated (for documentation purpose)

Please check whether the PR fulfills the following requirements

the commit message follows the guideline:
https://github.com/SAP/fundamental-ngx/blob/master/CONTRIBUTING.md
tests for the changes that have been done

Documentation checklist:

Documentation Examples

Screenshots

Before

Segmented button API not built

Options not marked as deprecated

The default value for params are missing

RTL mode not working

After

Segmented button API not built

Options not marked as deprecated

The default value for params are missing

RTL mode not working

CLAassistant · 2020-03-24T10:43:07Z

All committers have signed the CLA.

InnaAtanasova · 2020-03-24T19:01:12Z

apps/docs/src/app/core/component-docs/button/button-docs.component.html

@@ -18,7 +18,7 @@
 <separator></separator>

 <fd-docs-section-title [id]="'Button-sizes'" [componentName]="'button'"> Button Sizes </fd-docs-section-title>
-<description> Use <code class="code-snippet">[compact]="true"</code> for the mobile button size. </description>
+<description> Use (or skip) <code class="code-snippet">[compact]="false"</code> for the mobile button size. </description>


@Vanessa-Cusmich

InnaAtanasova · 2020-03-24T19:10:13Z

...core/component-docs/split-button/examples/split-button-programmatical-example.component.html

+<button class="programmable-button" fd-button (click)="isOpen=true">Open</button>
+<button class="programmable-button" fd-button (click)="isOpen=false">Close</button>


I have mixed feelings about this :D

I changed the class to docs-button

InnaAtanasova · 2020-03-24T19:10:41Z

libs/core/src/lib/button/button.component.ts

+    | 'positive'
+    | 'negative'
+    | 'attention'
+    | 'half'


Are we keeping the half button? @droshev

I don't want to keep something that is not part of Fiori 3. At least not in the API

I removed half from docs but for now I didn't remove half from component

InnaAtanasova · 2020-03-24T19:11:20Z

libs/core/src/lib/button/button.component.ts

@@ -41,50 +52,58 @@ export class ButtonComponent implements OnInit, CssClassBuilder {
        this._change();
    } // user's custom classes


This comment should be TypeDocs

Changes applied

InnaAtanasova · 2020-03-24T19:13:27Z

libs/core/src/lib/segmented-button/segmented-button.component.ts

@@ -23,5 +23,5 @@ export class SegmentedButtonComponent {

    /** @hidden */
    @HostBinding('class.fd-segmented-button')
-    fdButtonGroupClass: boolean = true;
+    fdsegmentedButtonClass: boolean = true;


maybe fdSegmentedButtonClass?

Thats the reason for using fd prefix for variable names?

variable name changed

InnaAtanasova

I left a few comments but they are minor so feel free to merge it once @droshev approves. It's good to have everything merged to feat/button-dialog-fonts so we test it tomorrow

* fix: few fixes in the code and documentation found after tests * small fixes * workaround added to fix missing selector * fix: addresing pr comments

…2224) * feat: addopt styles for buttons to match fiori 3 * fix: bring icons and fonts (#2187) * fix: Migrate modal to dialog support Fiori3 design and features (#2189) * fix(core) rename modal to dialog * Reworking dialogs header * Refactor dialogs footer * fix(core) Add draggable dialog support * fix(core) Improve dynamic component and dialog service code * fix(core) Introduce custom injector to DynamicComponents | Inject configs to Alert and Notification * fix(core) Create new Dialog Container | Use InjectionTokens with parent assecuration * fix(core) Create resize directive * Update Dialog documentation * fix(core) Add responsive paddings feature to dialog * fix(core) Add CssClassBuilders to Dialog and DialogContainer * fix(core) Update descriptions * fIX(Core) Revert Alert and Notification changes * fix(core) Add unit tests * fix(core) update missing buttons adnotations * fix(core) Update popover example * fix(core) Fix indirect imports * fix(core) Add loading state do Dialog * fix(core) Update tests * fix(core) Update tests * fix(core) Fix alert and notifications * fix(core) Address PR requests * fix(core) Fix resize for IE11 * fix: button fiori3 fixes and documentation improvements (#2221) * fix: few fixes in the code and documentation found after tests * small fixes * workaround added to fix missing selector * fix: addresing pr comments * fix: bring icons to angular.json file (#2227) * changes to support new code contribution guidline * fix(core) Add footer buttons wrapper * fix(core) Apply documentation changes according to PR comments * added ngoninit to button * fix(core) Create 'closestElement' function * Update button-docs.component.html * Update date-picker-complex-i18n-example.component.html * Update dialog-docs-header.component.html * Update dialog-docs.component.html * Update component-based-dialog-example.component.ts * Update dialog-backdrop-container-example.component.ts * fix closestElement tests * chore: bump styles and theming package versions * fix: remove dialog styling * fix: shellbar product menu markup update * menu button fixed * fix(core) fix Dialog styles | Change dialog buttons order * Add NODE_OPTIONS to netlify.toml * feat: fd-button--transparent added to input-group component * fix shellbar styling issues * chore: bump fundamental-styles version * fix(core) Clear selected products in complex dialog example Co-authored-by: Gracjan Górecki <gorecki.gracjan@hotmail.com> Co-authored-by: Inna Atanasova <39598672+InnaAtanasova@users.noreply.github.com> Co-authored-by: Vanessa-Cusmich <54723167+Vanessa-Cusmich@users.noreply.github.com> Co-authored-by: deno <mladen.droshev@sap.com> Co-authored-by: Mike O'Donnell <mikerodonnell89@users.noreply.github.com>

rengare added the v.0.16.0 label Mar 24, 2020

rengare added this to the Sprint 33 - London milestone Mar 24, 2020

rengare requested a review from a team March 24, 2020 10:43

rengare self-assigned this Mar 24, 2020

fix: few fixes in the code and documentation found after tests

ff50df6

rengare force-pushed the fix/button-fiori3-fixes branch from bc39583 to ff50df6 Compare March 24, 2020 10:52

InnaAtanasova reviewed Mar 24, 2020

View reviewed changes

rengare added 2 commits March 25, 2020 10:07

small fixes

22082a1

workaround added to fix missing selector

9bb4e4d

droshev approved these changes Mar 25, 2020

View reviewed changes

fix: addresing pr comments

fd08429

rengare requested review from InnaAtanasova and salarenko March 25, 2020 14:18

rengare merged commit ad366e7 into feat/button-dialog-fonts Mar 25, 2020

salarenko mentioned this pull request Mar 25, 2020

feat: Button in FIori3 | Dialog in Fiori3 | New way of adding Icons #2224

Merged

6 tasks

rengare deleted the fix/button-fiori3-fixes branch March 25, 2020 14:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: button fiori3 fixes and documentation improvements #2221

fix: button fiori3 fixes and documentation improvements #2221

rengare commented Mar 24, 2020

CLAassistant commented Mar 24, 2020 •

edited

Loading

InnaAtanasova Mar 24, 2020

InnaAtanasova Mar 24, 2020

rengare Mar 25, 2020

InnaAtanasova Mar 24, 2020

droshev Mar 24, 2020

rengare Mar 25, 2020

InnaAtanasova Mar 24, 2020

rengare Mar 25, 2020

InnaAtanasova Mar 24, 2020

salarenko Mar 25, 2020

rengare Mar 25, 2020

InnaAtanasova left a comment

		<button class="programmable-button" fd-button (click)="isOpen=true">Open</button>
		<button class="programmable-button" fd-button (click)="isOpen=false">Close</button>

		@@ -41,50 +52,58 @@ export class ButtonComponent implements OnInit, CssClassBuilder {
		this._change();
		} // user's custom classes

fix: button fiori3 fixes and documentation improvements #2221

fix: button fiori3 fixes and documentation improvements #2221

Conversation

rengare commented Mar 24, 2020

Please provide a link to the associated issue.

Please provide a brief summary of this pull request.

Please check whether the PR fulfills the following requirements

Screenshots

Before

After

CLAassistant commented Mar 24, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

InnaAtanasova left a comment

Choose a reason for hiding this comment

CLAassistant commented Mar 24, 2020 •

edited

Loading