Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed broken postinstall script that caused installation problems #1342

Closed
wants to merge 1 commit into from
Closed

fix: Fixed broken postinstall script that caused installation problems #1342

wants to merge 1 commit into from

Conversation

ChristianKienle
Copy link

npm i fiori-fundamentals is currently broken. This fixes it. Although I am not 100% sure that this addresses the root problem.

Maybe we could also add some kind of test to ensure this does not happen again?

@ChristianKienle ChristianKienle marked this pull request as ready for review March 22, 2019 09:47
@ChristianKienle
Copy link
Author

closing in favor #1343

@ChristianKienle ChristianKienle deleted the fix/fixes-broken-postinstall branch March 22, 2019 10:11
@joseegm
Copy link
Contributor

joseegm commented Mar 22, 2019

The Preview deployment for this PR failed.

Built with commit aed7b01

https://app.netlify.com/sites/fundamental/deploys/5c94ae983fa6120007c6d10b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants