Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move postinstall script #1343

Merged
merged 2 commits into from
Mar 22, 2019
Merged

fix: move postinstall script #1343

merged 2 commits into from
Mar 22, 2019

Conversation

jbadan
Copy link
Contributor

@jbadan jbadan commented Mar 22, 2019

npm i on newest versions of fiori-fundamentals is failing due to postinstall script.

Screen Shot 2019-03-22 at 2 55 20 AM

Renaming and moving the postinstall config generator to build-doc and start should solve this problem as it should only need to be run by devs and travis to grab the current version for the docs site.

@joseegm
Copy link
Contributor

joseegm commented Mar 22, 2019

Test Version for this PR was deployed

Built with commit 9050e83

https://deploy-preview-1343--fundamental.netlify.com

@jbadan jbadan merged commit cf30b83 into master Mar 22, 2019
@jbadan jbadan deleted the fix/install-issues branch March 22, 2019 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants