Update modal settings after openNodeInModal (#3554)

SAP · Dec 4, 2023 · b9ba189 · b9ba189
1 parent e511ad3
commit b9ba189
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/core/src/services/routing.js b/core/src/services/routing.js
@@ -521,7 +521,7 @@ class RoutingClass {
     if (additionalModalPath) {
       const modalParams = RoutingHelpers.getModalParamsFromPath();
       const { nodeObject } = await Navigation.extractDataFromPath(additionalModalPath);
-      LuigiNavigation.openAsModal(additionalModalPath, nodeObject.openNodeInModal || modalParams);
+      LuigiNavigation.openAsModal(additionalModalPath, modalParams || nodeObject.openNodeInModal);
     }
   }
 

diff --git a/core/test/services/routing.spec.js b/core/test/services/routing.spec.js
@@ -1259,7 +1259,7 @@ describe('Routing', function() {
       // then
       sinon.assert.calledWith(Navigation.extractDataFromPath, modalPath);
       sinon.assert.calledOnce(LuigiNavigation.openAsModal);
-      sinon.assert.calledWithExactly(LuigiNavigation.openAsModal, modalPath, mockNodeModalSettings.openNodeInModal);
+      sinon.assert.calledWithExactly(LuigiNavigation.openAsModal, modalPath, modalParams);
     });
   });
   describe('append and remove modal data from URL using path routing', () => {