Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update modal settings after openNodeInModal #3554

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Update modal settings after openNodeInModal #3554

merged 4 commits into from
Dec 4, 2023

Conversation

JohannesDoberer
Copy link
Contributor

Fixes #3551

@JohannesDoberer JohannesDoberer added the bug Something isn't working label Dec 1, 2023
@JohannesDoberer JohannesDoberer changed the title Update modal settings after open node in modal Update modal settings after openNodeInModal Dec 1, 2023
@JohannesDoberer JohannesDoberer merged commit b9ba189 into main Dec 4, 2023
12 checks passed
@JohannesDoberer JohannesDoberer deleted the updateModalSettings-after-openNodeInModal branch December 4, 2023 09:10
@JohannesDoberer JohannesDoberer mentioned this pull request Dec 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardl hardl hardl approved these changes

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

@ndricimrr ndricimrr Awaiting requested review from ndricimrr ndricimrr is a code owner

@VincentUllal VincentUllal Awaiting requested review from VincentUllal VincentUllal is a code owner

@camelCaseChris camelCaseChris Awaiting requested review from camelCaseChris

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

openNodeInModal width and height setting cannot be overriden
2 participants
@JohannesDoberer @hardl