Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation fixes #1003

Merged
merged 20 commits into from
Jan 15, 2020
Merged

Conversation

alexandra-simeonova
Copy link
Contributor

Description

Changes proposed in this pull request:

  • fixing typos
  • adding more information such as defaults for parameters
  • include configuration example in the "examples section"
  • various fixes

@alexandra-simeonova alexandra-simeonova added the documentation documentation tasks label Dec 3, 2019
@alexandra-simeonova alexandra-simeonova added this to the Sprint 8 milestone Dec 3, 2019
@JohannesDoberer JohannesDoberer self-assigned this Dec 16, 2019
Copy link
Contributor

@maxmarkus maxmarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added suggestion for an example.

docs/navigation-advanced.md Outdated Show resolved Hide resolved
Co-Authored-By: Markus <1720843+maxmarkus@users.noreply.github.com>
@maxmarkus maxmarkus self-assigned this Dec 16, 2019
Copy link
Contributor

@maxmarkus maxmarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@JohannesDoberer JohannesDoberer modified the milestones: Sprint 8, Sprint 9 Jan 13, 2020
@alexandra-simeonova alexandra-simeonova merged commit 7085b1a into SAP:master Jan 15, 2020
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Feb 12, 2020
* master:
  Debug cypress travis issue (SAP#1097)
  Fix communication from external mf using customMessages (SAP#1081)
  fix fd-modal mix-up (SAP#1068)
  who is using luigi in about page (SAP#1077)
  Add cobrick logo (SAP#1072)
  who is using luigi button (SAP#1066)
  Update README.md
  Update README.md
  release v0.7.4 (SAP#1069)
  fix items calculation in more btn of tab nav(SAP#1065)
  Add valid href to navigation links (SAP#1034)
  fix runtime error when contextSwitcher is not defined (SAP#1047)
  Improve API documentation (SAP#1025)
  Improve authorization doc structure (SAP#1024)
  Improve Overview page (SAP#1000)
  Improve application-setup.md (SAP#965)
  create content guidelines (#877)
  Documentation fixes (SAP#1003)

# Conflicts:
#	docs/luigi-core-api.md
#	test/e2e.sh
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
* various fixes
* example information
* tab nav illustration
* fix
* add defaults to parameters
* fix pics
* Update docs/navigation-advanced.md

Co-Authored-By: Markus <1720843+maxmarkus@users.noreply.github.com
Co-authored-by: JohannesDoberer <johannes.doberer@sap.com>
Co-authored-by: Markus <1720843+maxmarkus@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants