Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fd-modal mix-up #1068

Conversation

JohannesDoberer
Copy link
Contributor

No description provided.

@JohannesDoberer JohannesDoberer added this to the Sprint 9 milestone Jan 30, 2020
@JohannesDoberer JohannesDoberer added the bug Something isn't working label Jan 30, 2020
@marynaKhromova marynaKhromova self-assigned this Jan 30, 2020
@zarkosimic zarkosimic self-assigned this Jan 30, 2020
Copy link
Contributor

@marynaKhromova marynaKhromova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@JohannesDoberer JohannesDoberer merged commit 5469bcc into SAP:master Feb 3, 2020
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Feb 3, 2020
* master:
  fix fd-modal mix-up (SAP#1068)
  who is using luigi in about page (SAP#1077)
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Feb 12, 2020
* master:
  Debug cypress travis issue (SAP#1097)
  Fix communication from external mf using customMessages (SAP#1081)
  fix fd-modal mix-up (SAP#1068)
  who is using luigi in about page (SAP#1077)
  Add cobrick logo (SAP#1072)
  who is using luigi button (SAP#1066)
  Update README.md
  Update README.md
  release v0.7.4 (SAP#1069)
  fix items calculation in more btn of tab nav(SAP#1065)
  Add valid href to navigation links (SAP#1034)
  fix runtime error when contextSwitcher is not defined (SAP#1047)
  Improve API documentation (SAP#1025)
  Improve authorization doc structure (SAP#1024)
  Improve Overview page (SAP#1000)
  Improve application-setup.md (SAP#965)
  create content guidelines (#877)
  Documentation fixes (SAP#1003)

# Conflicts:
#	docs/luigi-core-api.md
#	test/e2e.sh
@JohannesDoberer JohannesDoberer deleted the fix-side-effects-when-multiple-fd-modals-in-dom-tree branch March 27, 2020 08:52
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Co-authored-by: Zarko Simic <42171300+zarkosimic@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants