Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update fundamental styles library version in angular example 0.8.1 #1245

Merged
merged 38 commits into from
Apr 24, 2020
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
7f95966
1229 Update the Fundamental library version to 0.7.0 for Angular App
UlianaMunich Apr 7, 2020
e8440d1
fix tests after changing the modal layoutt
UlianaMunich Apr 7, 2020
0b495a1
forgot a square inn tests
UlianaMunich Apr 7, 2020
6561d92
update the README.md for fiddle and upgrade the version of angular ex…
UlianaMunich Apr 7, 2020
95166ad
cleanup the README.md file for fiddle
UlianaMunich Apr 8, 2020
47ec011
Merge branch 'master' into 1229-update-fd-in-angular
alexandra-simeonova Apr 8, 2020
09e3114
Merge branch 'master' into 1229-update-fd-in-angular
UlianaMunich Apr 8, 2020
4b08826
Merge branch 'master' into 1229-update-fd-in-angular
UlianaMunich Apr 8, 2020
59e81ce
Fix issue with top navbar on the page and re-login button
UlianaMunich Apr 8, 2020
c00e2e4
fix issues with fonts and icons from sap-theming
UlianaMunich Apr 9, 2020
c7b5e0a
remove unnecessary badges from examples
UlianaMunich Apr 9, 2020
5b1c7f1
Merge branch 'master' into 1229-update-fd-in-angular
UlianaMunich Apr 14, 2020
7b10437
Merge branch 'master' of github.com:UlianaMunich/luigi into 1229-upda…
UlianaMunich Apr 14, 2020
de34cc5
replace old spinner with loading indicator
UlianaMunich Apr 16, 2020
c339b9d
Merge branch 'master' of github.com:UlianaMunich/luigi into 1229-upda…
UlianaMunich Apr 17, 2020
3e72a6d
replace fd-alert with fd-message-strip
UlianaMunich Apr 17, 2020
37b9f61
update list group
UlianaMunich Apr 20, 2020
5c7ec4f
Merge branch '1229-update-fd-in-angular' of github.com:UlianaMunich/l…
UlianaMunich Apr 20, 2020
865f0b9
Merge branch 'master' of github.com:UlianaMunich/luigi into 1229-upda…
UlianaMunich Apr 20, 2020
6ff1158
cleanup css
UlianaMunich Apr 20, 2020
235d73e
Merge branch 'master' into 1229-update-fd-in-angular
marynaKhromova Apr 21, 2020
a64952a
Merge branch 'master' into 1229-update-fd-in-angular
maxmarkus Apr 21, 2020
523da5e
fix issues with navigation tests and modal
UlianaMunich Apr 21, 2020
95a9aff
Merge branch '1229-update-fd-in-angular' of github.com:UlianaMunich/l…
UlianaMunich Apr 21, 2020
37bec24
remove not needed tests changes and remove angular example update
UlianaMunich Apr 21, 2020
835f365
style the logout page
UlianaMunich Apr 21, 2020
a274760
Merge branch 'master' into 1229-update-fd-in-angular
zarkosimic Apr 22, 2020
8c09545
Update website/fiddle/README.md
UlianaMunich Apr 22, 2020
74cc43a
Merge branch 'master' into 1229-update-fd-in-angular
zarkosimic Apr 23, 2020
c9490aa
add fonts and icons to angular and include styles.css into main views
UlianaMunich Apr 23, 2020
f086fa0
Merge branch '1229-update-fd-in-angular' of github.com:UlianaMunich/l…
UlianaMunich Apr 23, 2020
5e228e3
relocate fixes for dialog/modal
UlianaMunich Apr 23, 2020
a6c84c9
Merge branch 'master' into 1229-update-fd-in-angular
zarkosimic Apr 24, 2020
f549b28
add 460px width to a modal and clean it
UlianaMunich Apr 24, 2020
04a34e8
Merge branch '1229-update-fd-in-angular' of github.com:UlianaMunich/l…
UlianaMunich Apr 24, 2020
fd5da82
Merge branch 'master' into 1229-update-fd-in-angular
maxmarkus Apr 24, 2020
3f545eb
Merge branch 'master' into 1229-update-fd-in-angular
zarkosimic Apr 24, 2020
9db48fc
Merge branch 'master' into 1229-update-fd-in-angular
UlianaMunich Apr 24, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ describe('Luigi Client ux manager features', () => {
cy.get('.lui-backdrop').should('exist');
//close modal
cy.wrap($iframeBody)
.find('.fd-modal__footer')
.find('.fd-dialog__footer')
.contains('Confirm')
.click();

Expand Down
34 changes: 3 additions & 31 deletions test/e2e-test-application/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion test/e2e-test-application/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"@luigi-project/core": "1.0.0",
"ajv": "^6.1.1",
"core-js": "^2.4.1",
"fundamental-styles": "^0.6.0",
"fundamental-styles": "^0.8.1",
"rxjs": "6.2.0",
"zone.js": "^0.8.14",
"lodash": ">=4.17.13"
Expand Down
3 changes: 3 additions & 0 deletions test/e2e-test-application/src/app/app.component.scss
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,6 @@ $fd-icons-path: '~fundamental-styles/scss/icons/';
.fd-list-group__item {
display: block;
}
.fd-dialog {
z-index: 2;
}
Original file line number Diff line number Diff line change
@@ -1,38 +1,47 @@
<div
*ngIf="modalActive"
class="fd-ui__overlay fd-overlay fd-overlay--modal"
class="fd-dialog fd-dialog--active fd-dialog-docs-static"
UlianaMunich marked this conversation as resolved.
Show resolved Hide resolved
role="dialog"
data-testid="luigi-confirmation-modal"
aria-hidden="false"
>
<div class="fd-modal" role="dialog">
<div class="fd-modal__content" role="document">
<header class="fd-modal__header">
<h1 class="fd-modal__title">Modal Header</h1>
<button
(click)="onCloseModalClick()"
class="fd-button--light fd-modal__close sap-icon--decline sap-icon--l"
aria-label="close"
></button>
</header>
<div class="fd-modal__body">
<p>
Lorem tipsum dolor sit amet, consectetur adipisicing elit, sed do
eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad
minim veniam, quis nostrud exercitation ullamco laboris nisi ut
aliquip ex ea commodo consequat. Duis aute irure dolor in
reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla
pariatur.
</p>
<div class="fd-dialog__content fd-dialog__content--s">
<header class="fd-dialog__header fd-bar fd-bar--header">
<div class="fd-bar__left">
<div class="fd-bar__element">
<h1 class="fd-dialog__title">Modal Header</h1>
</div>
</div>
<footer class="fd-modal__footer">
<div class="fd-modal__actions">
<button (click)="onCloseModalClick()" class="fd-button--light">
Cancel
</button>
<button (click)="onCloseModalClick()" class="fd-button">
</header>
<div class="fd-dialog__body">
<p>
Lorem tipsum dolor sit amet, consectetur adipisicing elit, sed do
eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad
minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip
ex ea commodo consequat. Duis aute irure dolor in reprehenderit in
voluptate velit esse cillum dolore eu fugiat nulla pariatur.
</p>
</div>
<footer class="fd-dialog__footer fd-bar fd-bar--footer">
<div class="fd-bar__right">
<div class="fd-bar__element">
<button
(click)="onCloseModalClick()"
class="fd-dialog__decisive-button fd-button fd-button--emphasized fd-button--compact"
>
Confirm
</button>
</div>
</footer>
</div>
<div class="fd-bar__element">
<button
(click)="onCloseModalClick()"
class="fd-dialog__decisive-button fd-button fd-button--transparent fd-button--compact"
aria-label="close"
>
Cancel
</button>
</div>
</div>
</footer>
</div>
</div>
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
:host .fd-dialog__content {
max-width: 460px;
}
8 changes: 8 additions & 0 deletions website/fiddle/README.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
[![Netlify Status](https://api.netlify.com/api/v1/badges/6e36180d-2486-4daf-80a5-90a0ab363992/deploy-status)](https://app.netlify.com/sites/relaxed-kowalevski-49f468/deploys)

Luigi fiddle, deployed via netlify and accessible at https://fiddle.luigi-project.io
Go to the [Luigi Fiddle](https://fiddle.luigi-project.io) site to see Luigi in action and configure a sample application.

### Code formatting for contributors
UlianaMunich marked this conversation as resolved.
Show resolved Hide resolved

Run the `npm install` command in the root folder to install it.

### Run fiddle locally
`npm run dev`