update fundamental styles library version in angular example 0.8.1 #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UlianaMunich
requested review from
alexandra-simeonova,
hardl,
JohannesDoberer,
marynaKhromova,
maxmarkus,
pekura and
zarkosimic
as code owners
UlianaMunich
added
good first issue
alexandra-simeonova
approved these changes
Apr 8, 2020
marynaKhromova
suggested changes
Apr 8, 2020
There was a problem hiding this comment.
Hi @UlianaMunich, please check the screenshots I've attached to the PR.
In general, there are a couple of issues:
- SAP fonts and icons are missing
- some buttons need to be reworked
- problems with action bar
Please take into account that the screenshots are only the examples and it can happen that there are more places with the same issues, so I would suggest searching for classes in a whole folder e2e-test-application.
|
|
…uigi into 1229-update-fd-in-angular
…uigi into 1229-update-fd-in-angular
marynaKhromova
suggested changes
Apr 21, 2020
There was a problem hiding this comment.
Hi @UlianaMunich . Please check the comments below.
On logout page there are some spaces on the top and left side. Probably default browser styles that have to be reset. Also, there is still an Arial font, instead of SAP font.
Something wrong with font color when you click the button
Co-Authored-By: Aleksandra Simeonova <aleksandra.simeonova@sap.com>
…uigi into 1229-update-fd-in-angular
marynaKhromova
approved these changes
Apr 24, 2020
test/e2e-test-application/src/app/project/modal/modal.component.html
Outdated
Show resolved
Hide resolved
…uigi into 1229-update-fd-in-angular
JohannesDoberer
added a commit
to JohannesDoberer/luigi
that referenced
this pull request
Apr 27, 2020
* master: updated luigi version in fiddle and docs website (SAP#1298) Refactor Svelte example app (SAP#1270) Release v1.1.0 (SAP#1297) update fundamental styles library version in angular example 0.8.1 (SAP#1245) Fix semicollapsible issue (SAP#1292) Translate tooltip text in semi collapsed mode and add title attributes to entries in left nav (SAP#1283) Oidc provider uses storage type also for oidc client configuration (SAP#1269)
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
…AP#1245) * 1229 Update the Fundamental library version to 0.7.0 for Angular App * fix tests after changing the modal layoutt * forgot a square inn tests * update the README.md for fiddle and upgrade the version of angular example to 0.8.1 * cleanup the README.md file for fiddle * Fix issue with top navbar on the page and re-login button * fix issues with fonts and icons from sap-theming * remove unnecessary badges from examples * replace old spinner with loading indicator * replace fd-alert with fd-message-strip * update list group * cleanup css * fix issues with navigation tests and modal * remove not needed tests changes and remove angular example update * style the logout page * Update website/fiddle/README.md Co-Authored-By: Aleksandra Simeonova <aleksandra.simeonova@sap.com> * add fonts and icons to angular and include styles.css into main views * relocate fixes for dialog/modal * add 460px width to a modal Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com> Co-authored-by: marynaKhromova <46446373+marynaKhromova@users.noreply.github.com> Co-authored-by: Markus <1720843+maxmarkus@users.noreply.github.com> Co-authored-by: Zarko Simic <42171300+zarkosimic@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1229