Oidc provider uses storage type also for oidc client configuration #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxmarkus
added
enhancement
maxmarkus
requested review from
alexandra-simeonova,
hardl,
JohannesDoberer,
marynaKhromova,
pekura and
zarkosimic
as code owners
maxmarkus
changed the title
…luigi into 1190-oidc-align-storage-types
JohannesDoberer
added a commit
to JohannesDoberer/luigi
that referenced
this pull request
Apr 27, 2020
* master: updated luigi version in fiddle and docs website (SAP#1298) Refactor Svelte example app (SAP#1270) Release v1.1.0 (SAP#1297) update fundamental styles library version in angular example 0.8.1 (SAP#1245) Fix semicollapsible issue (SAP#1292) Translate tooltip text in semi collapsed mode and add title attributes to entries in left nav (SAP#1283) Oidc provider uses storage type also for oidc client configuration (SAP#1269)
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OIDC Provider now respects the
auth.storagesetting and uses the same storage not only for Luigi but also for the oidc client library.How to test with e2e application:
docker-compose upauth.usetoopenIdConnectauth.storagetype you want to testTest all three cases.
Fixes #1190