-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Youtube section to the landing page and Documentation #1315
Add Youtube section to the landing page and Documentation #1315
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @UlianaMunich . Please take a look at the comments below.
On a large resolution, I would recommend increasing a little bit of a bottom padding.
website/landingpage/dev/src/assets/scss/components/_home_page.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
* master: Migrate setup scripts to v1 (#1325) Add pre commit hook (#1344) Update npm dependencies in luigi-landingpage (#1346) Added read-only keyword labels to documentation (#1313) Cleanup the mock login page (#1340) Enable nightly builds (#1334) Fix input validation in fiddle idpmock (#1309) change travis to fix only on push to master (#1338) added selected state (#1326) Migrate example apps to v1 (#1311) Provide config in JS format to Fiddle e2e tests (#1305) Add Youtube section to the landing page and Documentation (#1315) Add a note about loadingIndicator to pageErrorHandler (#1310) Run compatibility tests in ci (#1307) Add possibility to unload Luigi (#1304)
* master: Enable nightly builds (SAP#1334) Fix input validation in fiddle idpmock (SAP#1309) change travis to fix only on push to master (SAP#1338) added selected state (SAP#1326) Migrate example apps to v1 (SAP#1311) Provide config in JS format to Fiddle e2e tests (SAP#1305) Add Youtube section to the landing page and Documentation (SAP#1315) Add a note about loadingIndicator to pageErrorHandler (SAP#1310) Run compatibility tests in ci (SAP#1307) Add possibility to unload Luigi (SAP#1304)
* feature-globalsearch: Migrate setup scripts to v1 (SAP#1325) Add pre commit hook (SAP#1344) Update npm dependencies in luigi-landingpage (SAP#1346) Added read-only keyword labels to documentation (SAP#1313) Cleanup the mock login page (SAP#1340) Enable nightly builds (SAP#1334) Fix input validation in fiddle idpmock (SAP#1309) change travis to fix only on push to master (SAP#1338) added selected state (SAP#1326) Migrate example apps to v1 (SAP#1311) Provide config in JS format to Fiddle e2e tests (SAP#1305) Add Youtube section to the landing page and Documentation (SAP#1315) Add a note about loadingIndicator to pageErrorHandler (SAP#1310) Run compatibility tests in ci (SAP#1307) Add possibility to unload Luigi (SAP#1304)
* search-provider-interface: Migrate setup scripts to v1 (SAP#1325) Add pre commit hook (SAP#1344) Update npm dependencies in luigi-landingpage (SAP#1346) Added read-only keyword labels to documentation (SAP#1313) Cleanup the mock login page (SAP#1340) Enable nightly builds (SAP#1334) Fix input validation in fiddle idpmock (SAP#1309) change travis to fix only on push to master (SAP#1338) added selected state (SAP#1326) Migrate example apps to v1 (SAP#1311) Provide config in JS format to Fiddle e2e tests (SAP#1305) Add Youtube section to the landing page and Documentation (SAP#1315) Add a note about loadingIndicator to pageErrorHandler (SAP#1310) Run compatibility tests in ci (SAP#1307) Add possibility to unload Luigi (SAP#1304)
* Add Youtube section to the landing page and link on the documentation page Co-authored-by: marynaKhromova <46446373+marynaKhromova@users.noreply.github.com>
Fixes #1240