Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

selected state for product switch items #1326

Merged
merged 4 commits into from
May 14, 2020
Merged

selected state for product switch items #1326

merged 4 commits into from
May 14, 2020
+9 −2

Conversation

hardl
Copy link
Contributor

@hardl hardl commented May 11, 2020

No description provided.

@hardl hardl added the enhancement New feature or request label May 11, 2020
@hardl hardl added this to the Sprint 10 milestone May 11, 2020
@marynaKhromova marynaKhromova self-assigned this May 12, 2020
@JohannesDoberer JohannesDoberer self-assigned this May 12, 2020
marynaKhromova
marynaKhromova approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@marynaKhromova marynaKhromova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@hardl hardl merged commit 3ece9d0 into SAP:master May 14, 2020
@hardl hardl deleted the product-switch-selection branch May 14, 2020 12:26
JohannesDoberer added a commit that referenced this pull request May 20, 2020
@JohannesDoberer
Merge branch 'master' into feature-globalsearch
ff7deb6 
* master:
  Migrate setup scripts to v1 (#1325)
  Add pre commit hook (#1344)
  Update npm dependencies in luigi-landingpage (#1346)
  Added read-only keyword labels to documentation (#1313)
  Cleanup the mock login page (#1340)
  Enable nightly builds (#1334)
  Fix input validation in fiddle idpmock (#1309)
  change travis to fix only on push to master (#1338)
  added selected state (#1326)
  Migrate example apps to v1 (#1311)
  Provide config in JS format to Fiddle e2e tests (#1305)
  Add Youtube section to the landing page and Documentation (#1315)
  Add a note about loadingIndicator to pageErrorHandler  (#1310)
  Run compatibility tests in ci (#1307)
  Add possibility to unload Luigi (#1304)
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request May 20, 2020
@JohannesDoberer
Merge branch 'master' into feature-globalsearch
f4c3726 
* master:
  Enable nightly builds (SAP#1334)
  Fix input validation in fiddle idpmock (SAP#1309)
  change travis to fix only on push to master (SAP#1338)
  added selected state (SAP#1326)
  Migrate example apps to v1 (SAP#1311)
  Provide config in JS format to Fiddle e2e tests (SAP#1305)
  Add Youtube section to the landing page and Documentation (SAP#1315)
  Add a note about loadingIndicator to pageErrorHandler  (SAP#1310)
  Run compatibility tests in ci (SAP#1307)
  Add possibility to unload Luigi (SAP#1304)
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request May 20, 2020
@JohannesDoberer
Merge branch 'feature-globalsearch' into search-provider-interface
3297aa9 
* feature-globalsearch:
  Migrate setup scripts to v1 (SAP#1325)
  Add pre commit hook (SAP#1344)
  Update npm dependencies in luigi-landingpage (SAP#1346)
  Added read-only keyword labels to documentation (SAP#1313)
  Cleanup the mock login page (SAP#1340)
  Enable nightly builds (SAP#1334)
  Fix input validation in fiddle idpmock (SAP#1309)
  change travis to fix only on push to master (SAP#1338)
  added selected state (SAP#1326)
  Migrate example apps to v1 (SAP#1311)
  Provide config in JS format to Fiddle e2e tests (SAP#1305)
  Add Youtube section to the landing page and Documentation (SAP#1315)
  Add a note about loadingIndicator to pageErrorHandler  (SAP#1310)
  Run compatibility tests in ci (SAP#1307)
  Add possibility to unload Luigi (SAP#1304)
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request May 20, 2020
@JohannesDoberer
Merge branch 'search-provider-interface' into closeSearchField
b350ad4 
* search-provider-interface:
  Migrate setup scripts to v1 (SAP#1325)
  Add pre commit hook (SAP#1344)
  Update npm dependencies in luigi-landingpage (SAP#1346)
  Added read-only keyword labels to documentation (SAP#1313)
  Cleanup the mock login page (SAP#1340)
  Enable nightly builds (SAP#1334)
  Fix input validation in fiddle idpmock (SAP#1309)
  change travis to fix only on push to master (SAP#1338)
  added selected state (SAP#1326)
  Migrate example apps to v1 (SAP#1311)
  Provide config in JS format to Fiddle e2e tests (SAP#1305)
  Add Youtube section to the landing page and Documentation (SAP#1315)
  Add a note about loadingIndicator to pageErrorHandler  (SAP#1310)
  Run compatibility tests in ci (SAP#1307)
  Add possibility to unload Luigi (SAP#1304)
@ndricimrr ndricimrr mentioned this pull request Jun 4, 2020
Merged
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@hardl
added selected state (SAP#1326)
32c0f70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohannesDoberer JohannesDoberer JohannesDoberer approved these changes

@marynaKhromova marynaKhromova marynaKhromova approved these changes

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

@maxmarkus maxmarkus Awaiting requested review from maxmarkus

@pekura pekura Awaiting requested review from pekura

@zarkosimic zarkosimic Awaiting requested review from zarkosimic

Assignees

@JohannesDoberer JohannesDoberer

@marynaKhromova marynaKhromova

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint 10
Development

Successfully merging this pull request may close these issues.
3 participants
@hardl @JohannesDoberer @marynaKhromova