Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New FAQ about micro frontend communication #1465

Merged
merged 6 commits into from
Jul 14, 2020
Merged

New FAQ about micro frontend communication #1465

merged 6 commits into from
Jul 14, 2020

Conversation

alexandra-simeonova
Copy link
Contributor

@alexandra-simeonova alexandra-simeonova commented Jul 7, 2020 •
edited by maxmarkus
Loading

Description

Changes proposed in this pull request:

  • Add a frequently asked question regarding communication between MFs and custom messages.
  • Modify the question of how to change Luigi's UI

Related issue(s)
Resolves #1461

@alexandra-simeonova alexandra-simeonova added the documentation documentation tasks label Jul 7, 2020
@alexandra-simeonova alexandra-simeonova added this to the Sprint 11 milestone Jul 7, 2020
@CLAassistant
Copy link

CLAassistant commented Jul 7, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ndricimrr ndricimrr self-assigned this Jul 10, 2020
ndricimrr
ndricimrr approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 👍

@UlianaMunich UlianaMunich self-assigned this Jul 10, 2020
UlianaMunich
UlianaMunich suggested changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@UlianaMunich UlianaMunich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A tiny suggestion to remove a "!" at the end of the statement. Other than that looks good to me!

docs/faq.md Outdated Show resolved Hide resolved
UlianaMunich
UlianaMunich approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@UlianaMunich UlianaMunich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexandra-simeonova alexandra-simeonova merged commit 1b571ba into SAP:master Jul 14, 2020
@alexandra-simeonova alexandra-simeonova deleted the 1461-faq-mfs branch July 14, 2020 06:49
JohannesDoberer added a commit that referenced this pull request Jul 16, 2020
@JohannesDoberer
Merge branch 'master' into feature-globalsearch
b673cdd 
* master:
  OIDC: Support for Authorization Code flow with PKCE (#1478)
  update dependency (#1486)
  Add semicolon line endings to prettier (#1481)
  Fix contextswitcher selected state (#1477)
  Blog feeds (#1469)
  Test external micro frontend (#1451)
  New FAQ about micro frontend communication (#1465)
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@alexandra-simeonova
New FAQ about micro frontend communication (SAP#1465)
3ad25c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UlianaMunich UlianaMunich UlianaMunich approved these changes

@ndricimrr ndricimrr ndricimrr approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@JohannesDoberer JohannesDoberer Awaiting requested review from JohannesDoberer JohannesDoberer is a code owner

@maxmarkus maxmarkus Awaiting requested review from maxmarkus

@stanleychh stanleychh Awaiting requested review from stanleychh

Assignees

@UlianaMunich UlianaMunich

@ndricimrr ndricimrr

Labels
documentation documentation tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New FAQ
4 participants
@alexandra-simeonova @CLAassistant @UlianaMunich @ndricimrr