Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OIDC: Support for Authorization Code flow with PKCE #1478

Merged
merged 11 commits into from
Jul 16, 2020
Merged

OIDC: Support for Authorization Code flow with PKCE #1478

merged 11 commits into from
Jul 16, 2020

Conversation

azriel46d
Copy link
Contributor

@azriel46d azriel46d commented Jul 9, 2020 •
edited
Loading

Description
Currently the plugin is expecting access_token to be part of the location.hash . So when the settings are set to authenticate using PKCE it causes an infinite redirect-login.
The PKCE flow changes in that the callback returns a code as part of the query string.

Changes proposed in this pull request:

  • This change addresses both PKCE and token based on what the response_type is set to. If token is set, then an access_token is expected as part of the hash , otherwise if code is set, it checks for it in the query string.

@CLAassistant
Copy link

CLAassistant commented Jul 9, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@maxmarkus maxmarkus added the auth authorization/authentication label Jul 9, 2020
@maxmarkus maxmarkus added this to the Sprint 11 milestone Jul 9, 2020
@maxmarkus maxmarkus self-assigned this Jul 9, 2020
@maxmarkus maxmarkus added the enhancement New feature or request label Jul 10, 2020
@maxmarkus maxmarkus changed the title support for PKCE code OIDC: Support for Auth Code PKCE flow Jul 10, 2020
@maxmarkus maxmarkus changed the title OIDC: Support for Auth Code PKCE flow OIDC: Support for Authorization Code flow with PKCE Jul 10, 2020
@maxmarkus maxmarkus mentioned this pull request Jul 10, 2020
Closed
@azriel46d @maxmarkus
Update test/e2e-test-application/src/luigi-config/extended/auth.js
e1bd8de 
Co-authored-by: Markus <1720843+maxmarkus@users.noreply.github.com>
maxmarkus
maxmarkus approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@maxmarkus maxmarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the awesome collaboration and your effort in finalising this PR! 🚀

@JohannesDoberer JohannesDoberer self-assigned this Jul 14, 2020
JohannesDoberer
JohannesDoberer approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for your contribution 👍 !Good job

@maxmarkus maxmarkus merged commit 3609aca into SAP:master Jul 16, 2020
JohannesDoberer added a commit that referenced this pull request Jul 16, 2020
@JohannesDoberer
Merge branch 'master' into feature-globalsearch
b673cdd 
* master:
  OIDC: Support for Authorization Code flow with PKCE (#1478)
  update dependency (#1486)
  Add semicolon line endings to prettier (#1481)
  Fix contextswitcher selected state (#1477)
  Blog feeds (#1469)
  Test external micro frontend (#1451)
  New FAQ about micro frontend communication (#1465)
@maxmarkus maxmarkus mentioned this pull request Jul 16, 2020
Merged
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@azriel46d
OIDC: Support for Authorization Code flow with PKCE (SAP#1478)
19c08a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxmarkus maxmarkus maxmarkus approved these changes

@JohannesDoberer JohannesDoberer JohannesDoberer approved these changes

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@stanleychh stanleychh Awaiting requested review from stanleychh

@ndricimrr ndricimrr Awaiting requested review from ndricimrr ndricimrr is a code owner

@UlianaMunich UlianaMunich Awaiting requested review from UlianaMunich

Assignees

@maxmarkus maxmarkus

@JohannesDoberer JohannesDoberer

Labels
auth authorization/authentication enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@azriel46d @CLAassistant @maxmarkus @JohannesDoberer