-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements on simpledev, live-server, etc #1543
Improvements on simpledev, live-server, etc #1543
Conversation
…rity-policy-refactor # Conflicts: # core/package-lock.json # core/webpack.config.js
Should we get rid of |
Some notes I pulled while looking at this in general. Probably helpful to keep track of why we changed it for future reference. Removed Parts:
History of removed parts:
Some results so farThere seem to be changes in bundle sizes: Before and after images from bundle analysis: Diff in size ≈ -100 KB Also, due to removing babel build configs, luigi.js.map file which is ≈ 980 KB is also omitted from the resulting build. As it's needed for source mapping (i.e: better debugging) might consider adding source mapping through webpack's devtool as an alternative. Could help to consider this article to argue with. On a side note need to discuss more about unsafe-inline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert all changes that are not related to the fix of the corresponding ticket, e.g. live-server, prettier, etc.
I am creating a new PR, this one stays and will be merged afterwards with followup improvements. |
…xmarkus/luigi into 1449-content-security-policy-refactor
This implementation has some side effects and it was for the purpose of allowing CSP in dev mode. |
Improvements after #1449, followup of #1565