Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve js bundle size #996

Merged
merged 6 commits into from
Dec 5, 2019
Merged

Improve js bundle size #996

merged 6 commits into from
Dec 5, 2019

Conversation

maxmarkus
Copy link
Contributor

  • added terser package and added to babel pipeline for smaller evergreen bundle size
  • added webpack analyzer plugin and added npm run helper:webpack-analyze command

@maxmarkus maxmarkus added this to the Sprint 8 milestone Nov 29, 2019
@zarkosimic zarkosimic self-assigned this Nov 29, 2019
@JohannesDoberer JohannesDoberer self-assigned this Dec 2, 2019
zarkosimic
zarkosimic approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@zarkosimic zarkosimic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@maxmarkus maxmarkus merged commit 9953db5 into SAP:master Dec 5, 2019
@maxmarkus maxmarkus deleted the improve-js-bundle-size branch December 5, 2019 10:11
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Dec 5, 2019
@JohannesDoberer
Merge branch 'master' into handle-init-in-luigi-client
774e8af 
* master:
  improve evergreen bundle-size by using terser, added webpack analyze command (SAP#996)
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Dec 5, 2019
@JohannesDoberer
Merge branch 'master' into custom-item-renderer-for-options-in-contex…
fdc3518 
…t-switcher

* master:
  CM-cookie-poisoning (SAP#1006)
  handle init in luigi client without init handshake (SAP#994)
  improve evergreen bundle-size by using terser, added webpack analyze command (SAP#996)
@JohannesDoberer JohannesDoberer mentioned this pull request Dec 6, 2019
Closed
@ndricimrr ndricimrr mentioned this pull request Aug 11, 2020
Closed
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@maxmarkus
improve evergreen bundle-size by using terser, added webpack analyze …
b833e11 
…command (SAP#996)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohannesDoberer JohannesDoberer JohannesDoberer approved these changes

@zarkosimic zarkosimic zarkosimic approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@marynaKhromova marynaKhromova Awaiting requested review from marynaKhromova

@pekura pekura Awaiting requested review from pekura

Assignees

@JohannesDoberer JohannesDoberer

@zarkosimic zarkosimic

Labels
None yet
Projects
None yet
Milestone
Sprint 8
Development

Successfully merging this pull request may close these issues.
3 participants
@maxmarkus @JohannesDoberer @zarkosimic