Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possibility to set document title without Luigi header config #1591

Merged
merged 6 commits into from
Sep 4, 2020
Merged

Possibility to set document title without Luigi header config #1591

merged 6 commits into from
Sep 4, 2020

Conversation

JohannesDoberer
Copy link
Contributor

No description provided.

@JohannesDoberer
set document title without header config
76d9ca4
@JohannesDoberer
Merge branch 'master' into possibility-to-set-title-without-header-co…
fb50cdf 
…nfig

* master:
  Add up arrow key press to global search (SAP#1587)
  fix e2e test (SAP#1589)
  Update fiddle fd styles to 0.11.0 (SAP#1581)
  Modal loading indicator and close Modal event (SAP#1578)
  Integrate plugin readme in docu (SAP#1564)
  Luigi sample with Next.js (SAP#1579)
  Update version of FD styles to the Core 0.10.0 -> 0.11.0 (SAP#1569)
@JohannesDoberer JohannesDoberer added the enhancement New feature or request label Aug 31, 2020
@JohannesDoberer JohannesDoberer added this to the Sprint 12 milestone Aug 31, 2020
@JohannesDoberer JohannesDoberer modified the milestones: Sprint 12, Sprint 13 Sep 2, 2020
@UlianaMunich UlianaMunich self-assigned this Sep 2, 2020
UlianaMunich
UlianaMunich approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@UlianaMunich UlianaMunich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stanleychh stanleychh self-assigned this Sep 3, 2020
@JohannesDoberer JohannesDoberer changed the title Possibility to set title without header config Possibility to set document title without Luigi header config Sep 4, 2020
@JohannesDoberer JohannesDoberer merged commit b88b6e1 into SAP:master Sep 4, 2020
@JohannesDoberer JohannesDoberer deleted the possibility-to-set-title-without-header-config branch September 4, 2020 09:53
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Sep 7, 2020
@JohannesDoberer
Merge branch 'master' into support-wc-in-modal-mf
e571f18 
* master:
  update npm dependencies (SAP#1599)
  Possibility to set document title without Luigi header config (SAP#1591)
  Bump bl from 3.0.0 to 3.0.1 in /website/docs (SAP#1602)
  Bump bl from 3.0.0 to 3.0.1 in /core (SAP#1601)
  Update fd styles core examples (SAP#1586)
  Update e2e App fdstyles with v.0.11.0 (SAP#1575)
@ndricimrr ndricimrr mentioned this pull request Sep 9, 2020
Merged
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@JohannesDoberer
Possibility to set document title without Luigi header config (SAP#1591)
eff96c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UlianaMunich UlianaMunich UlianaMunich approved these changes

@stanleychh stanleychh stanleychh approved these changes

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@maxmarkus maxmarkus Awaiting requested review from maxmarkus

@ndricimrr ndricimrr Awaiting requested review from ndricimrr ndricimrr is a code owner

Assignees

@UlianaMunich UlianaMunich

@stanleychh stanleychh

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint 13
Development

Successfully merging this pull request may close these issues.
3 participants
@JohannesDoberer @UlianaMunich @stanleychh