Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update npm dependencies #1599

Merged
merged 6 commits into from
Sep 7, 2020

Conversation

JohannesDoberer
Copy link
Contributor

No description provided.

@JohannesDoberer JohannesDoberer added the internal Stuff like NFRs, CI pipeline label Sep 2, 2020
@JohannesDoberer JohannesDoberer added this to the Sprint 13 milestone Sep 2, 2020
@ndricimrr ndricimrr self-assigned this Sep 2, 2020
@UlianaMunich UlianaMunich self-assigned this Sep 2, 2020
Copy link
Contributor

@UlianaMunich UlianaMunich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JohannesDoberer could you please check the packages which are dependant on dot-prop: https://www.npmjs.com/browse/depended/dot-prop?offset=36

I have found lerna only, which requires it. So maybe we could update lerna which will update dot-prop as result?

Copy link
Contributor

@UlianaMunich UlianaMunich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JohannesDoberer JohannesDoberer merged commit 2e8e7be into SAP:master Sep 7, 2020
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Sep 7, 2020
* master:
  update npm dependencies (SAP#1599)
  Possibility to set document title without Luigi header config (SAP#1591)
  Bump bl from 3.0.0 to 3.0.1 in /website/docs (SAP#1602)
  Bump bl from 3.0.0 to 3.0.1 in /core (SAP#1601)
  Update fd styles core examples (SAP#1586)
  Update e2e App fdstyles with v.0.11.0 (SAP#1575)
@ndricimrr ndricimrr mentioned this pull request Sep 9, 2020
@JohannesDoberer JohannesDoberer deleted the update-npm-dependencies branch September 9, 2020 12:24
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Stuff like NFRs, CI pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants