Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken angular link #1717

Merged
merged 2 commits into from
Nov 24, 2020
Merged

Fix broken angular link #1717

merged 2 commits into from
Nov 24, 2020

Conversation

stanleychh
Copy link
Contributor

@stanleychh stanleychh commented Nov 20, 2020 •
edited
Loading

Fixed #1711

  • remove the angular version
  • fix the broken docu link

@stanleychh stanleychh added the documentation documentation tasks label Nov 20, 2020
@alexandra-simeonova alexandra-simeonova self-assigned this Nov 20, 2020
@JohannesDoberer JohannesDoberer added this to the Sprint 14 milestone Nov 23, 2020
@stanleychh stanleychh merged commit 0c2c4f2 into SAP:master Nov 24, 2020
@stanleychh stanleychh deleted the 1711-docu-angular-link branch November 24, 2020 09:08
JohannesDoberer added a commit that referenced this pull request Nov 25, 2020
@JohannesDoberer
Merge branch 'master' into feature-user-settings
98d9f73 
* master:
  add blog post (#1731)
  Release v1.6.0 (#1729)
  cm fix (#1727)
  Added state info to replacestate (#1725)
  Simple storage api for micro frontends#1696 (#1707)
  Fix broken angular link (#1717)
  Fix css issue for Iframe (#1716)
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Nov 25, 2020
@JohannesDoberer
Merge branch 'feature-user-settings' into core-api-user-settings
8553ab7 
* feature-user-settings:
  add blog post (SAP#1731)
  Release v1.6.0 (SAP#1729)
  cm fix (SAP#1727)
  Profile setting dialog (SAP#1710)
  Added state info to replacestate (SAP#1725)
  Simple storage api for micro frontends#1696 (SAP#1707)
  Fix broken angular link (SAP#1717)
  Fix css issue for Iframe (SAP#1716)

# Conflicts:
#	test/e2e-test-application/src/luigi-config/extended/settings.js
stanleychh added a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@stanleychh
Fix broken angular link (SAP#1717)
43a96ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UlianaMunich UlianaMunich UlianaMunich approved these changes

@alexandra-simeonova alexandra-simeonova alexandra-simeonova approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@JohannesDoberer JohannesDoberer Awaiting requested review from JohannesDoberer JohannesDoberer is a code owner

@maxmarkus maxmarkus Awaiting requested review from maxmarkus

@ndricimrr ndricimrr Awaiting requested review from ndricimrr ndricimrr is a code owner

Assignees

@alexandra-simeonova alexandra-simeonova

Labels
documentation documentation tasks
Projects
None yet
Milestone
Sprint 14
Development

Successfully merging this pull request may close these issues.

Docu link broken
4 participants
@stanleychh @UlianaMunich @alexandra-simeonova @JohannesDoberer