1687 profile setting dialog #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohannesDoberer
requested review from
alexandra-simeonova,
hardl,
maxmarkus,
ndricimrr,
stanleychh and
UlianaMunich
as code owners
UlianaMunich
suggested changes
Nov 23, 2020
There was a problem hiding this comment.
Works well!
I left just a couple of comments to adjust and it is good to go.
Please check @JohannesDoberer
test/e2e-test-application/e2e/tests/0-fiddle/fiddle-navigation.spec.js
Outdated
Show resolved
Hide resolved
stanleychh
reviewed
Nov 23, 2020
test/e2e-test-application/e2e/tests/0-fiddle/fiddle-navigation.spec.js
Outdated
Show resolved
Hide resolved
stanleychh
reviewed
Nov 23, 2020
core/src/Authorization.html
Outdated
| const userSettings = await LuigiConfig.getConfigValueAsync( | ||
| 'settings.userSettings' | ||
| ); | ||
| isUserSettings = Boolean(userSettings); |
There was a problem hiding this comment.
I felt hasUserSettings more understandable. Otherwise, it should be isUserSettingsExisted. What do you think?
There was a problem hiding this comment.
Changed it into hasUserSettings.
JohannesDoberer
added a commit
to JohannesDoberer/luigi
that referenced
this pull request
Nov 25, 2020
* feature-user-settings: add blog post (SAP#1731) Release v1.6.0 (SAP#1729) cm fix (SAP#1727) Profile setting dialog (SAP#1710) Added state info to replacestate (SAP#1725) Simple storage api for micro frontends#1696 (SAP#1707) Fix broken angular link (SAP#1717) Fix css issue for Iframe (SAP#1716) # Conflicts: # test/e2e-test-application/src/luigi-config/extended/settings.js
legteodav
added a commit
that referenced
this pull request
Jan 19, 2021
* Profile setting dialog (#1710) * Read/write settings using core api (#1709) * Dialog box for user settings (#1750) known issue.. grid is not displayed correctly in ie11 * Adding new configuration for enum displayed as buttons * Update core/src/UserSettingsEditor.html Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * Changing testdataid with id in html attribute * Adding again testid * Update core/src/UserSettingsEditor.html Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * Update core/src/UserSettingsEditor.html Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * Update core/src/UserSettingsEditor.html Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * Update core/src/UserSettingsEditor.html Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * changing button to segment and group.... * Fixing integration tests Co-authored-by: JohannesDoberer <johannes.doberer@sap.com> Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>
legteodav
added a commit
to legteodav/luigi
that referenced
this pull request
Jan 19, 2021
* Profile setting dialog (SAP#1710) * Read/write settings using core api (SAP#1709) * Dialog box for user settings (SAP#1750) known issue.. grid is not displayed correctly in ie11 * Adding new configuration for enum displayed as buttons * Update core/src/UserSettingsEditor.html Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * Changing testdataid with id in html attribute * Adding again testid * Update core/src/UserSettingsEditor.html Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * Update core/src/UserSettingsEditor.html Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * Update core/src/UserSettingsEditor.html Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * Update core/src/UserSettingsEditor.html Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * changing button to segment and group.... * Fixing integration tests Co-authored-by: JohannesDoberer <johannes.doberer@sap.com> Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>
legteodav
added a commit
that referenced
this pull request
Jan 19, 2021
* First commit for wc * Adding example for WC * Adding Web Component Documentation * Doc changes * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update client-frameworks-support/client-support-angular/projects/client-support-angular/src/lib/route/luigi-activated-route-snapshot-helper.ts * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Fixing error in luigi core doc * Adding nv documentation * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update website/fiddle/public/wc/luigiExampleWC.js Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update website/fiddle/public/wc/luigiExampleWC.js Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update website/fiddle/public/wc/luigiExampleWC.js Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update website/fiddle/public/wc/luigiExampleWC.js Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Adding doc images * Update docs/luigi-core-api.md Co-authored-by: Uliana Caceres <2720077+UlianaMunich@users.noreply.github.com> * Removed unused file * Rename component title * removed white spaces * Adding clazz name to fiddle example, removign examples in the documentation * adding new fiddle component * Adding UI5 Component * Changing label UI5 components * Custom mf for user settings (#1802) * Rewrite getting started guide (#1766) * state-store fix (#1814) Co-authored-by: Stanley Hsu <ching.hsiang.hsu@sap.com> * ng support lib enhancements (#1809) Co-authored-by: JohannesDoberer <johannes.doberer@sap.com> * 1767 different visual appearances (#1790) * Profile setting dialog (#1710) * Read/write settings using core api (#1709) * Dialog box for user settings (#1750) known issue.. grid is not displayed correctly in ie11 * Adding new configuration for enum displayed as buttons * Update core/src/UserSettingsEditor.html Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * Changing testdataid with id in html attribute * Adding again testid * Update core/src/UserSettingsEditor.html Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * Update core/src/UserSettingsEditor.html Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * Update core/src/UserSettingsEditor.html Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * Update core/src/UserSettingsEditor.html Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * changing button to segment and group.... * Fixing integration tests Co-authored-by: JohannesDoberer <johannes.doberer@sap.com> Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * merging and resolving conflics * adding new fiddle component * Adding UI5 Component Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> Co-authored-by: Uliana Caceres <2720077+UlianaMunich@users.noreply.github.com> Co-authored-by: JohannesDoberer <johannes.doberer@sap.com> Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com> Co-authored-by: Philipp Pracht <philipp.pracht@sap.com> Co-authored-by: Stanley Hsu <ching.hsiang.hsu@sap.com> Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>
stanleychh
added a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
* Profile setting dialog (SAP#1710) * Read/write settings using core api (SAP#1709) * Dialog box for user settings (SAP#1750) known issue.. grid is not displayed correctly in ie11 * Adding new configuration for enum displayed as buttons * Update core/src/UserSettingsEditor.html Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * Changing testdataid with id in html attribute * Adding again testid * Update core/src/UserSettingsEditor.html Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * Update core/src/UserSettingsEditor.html Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * Update core/src/UserSettingsEditor.html Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * Update core/src/UserSettingsEditor.html Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * changing button to segment and group.... * Fixing integration tests Co-authored-by: JohannesDoberer <johannes.doberer@sap.com> Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>
stanleychh
added a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
* First commit for wc * Adding example for WC * Adding Web Component Documentation * Doc changes * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update client-frameworks-support/client-support-angular/projects/client-support-angular/src/lib/route/luigi-activated-route-snapshot-helper.ts * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Fixing error in luigi core doc * Adding nv documentation * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update docs/web-component.md Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update website/fiddle/public/wc/luigiExampleWC.js Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update website/fiddle/public/wc/luigiExampleWC.js Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update website/fiddle/public/wc/luigiExampleWC.js Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Update website/fiddle/public/wc/luigiExampleWC.js Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> * Adding doc images * Update docs/luigi-core-api.md Co-authored-by: Uliana Caceres <2720077+UlianaMunich@users.noreply.github.com> * Removed unused file * Rename component title * removed white spaces * Adding clazz name to fiddle example, removign examples in the documentation * adding new fiddle component * Adding UI5 Component * Changing label UI5 components * Custom mf for user settings (SAP#1802) * Rewrite getting started guide (SAP#1766) * state-store fix (SAP#1814) Co-authored-by: Stanley Hsu <ching.hsiang.hsu@sap.com> * ng support lib enhancements (SAP#1809) Co-authored-by: JohannesDoberer <johannes.doberer@sap.com> * 1767 different visual appearances (SAP#1790) * Profile setting dialog (SAP#1710) * Read/write settings using core api (SAP#1709) * Dialog box for user settings (SAP#1750) known issue.. grid is not displayed correctly in ie11 * Adding new configuration for enum displayed as buttons * Update core/src/UserSettingsEditor.html Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * Changing testdataid with id in html attribute * Adding again testid * Update core/src/UserSettingsEditor.html Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * Update core/src/UserSettingsEditor.html Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * Update core/src/UserSettingsEditor.html Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * Update core/src/UserSettingsEditor.html Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * changing button to segment and group.... * Fixing integration tests Co-authored-by: JohannesDoberer <johannes.doberer@sap.com> Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * merging and resolving conflics * adding new fiddle component * Adding UI5 Component Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com> Co-authored-by: Uliana Caceres <2720077+UlianaMunich@users.noreply.github.com> Co-authored-by: JohannesDoberer <johannes.doberer@sap.com> Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com> Co-authored-by: Philipp Pracht <philipp.pracht@sap.com> Co-authored-by: Stanley Hsu <ching.hsiang.hsu@sap.com> Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.