Provide a e2e test for "withoutSync()" bug fix #1744
Merged
+273
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legteodav
requested review from
alexandra-simeonova,
hardl,
JohannesDoberer,
maxmarkus,
ndricimrr,
stanleychh and
UlianaMunich
as code owners
ndricimrr
reviewed
Dec 10, 2020
ndricimrr
reviewed
Dec 10, 2020
ndricimrr
reviewed
Dec 10, 2020
ndricimrr
requested changes
Dec 10, 2020
test/e2e-test-application/e2e/tests/1-angular/navigation.spec.js
Outdated
Show resolved
Hide resolved
|
Waiting until #1760 is done. |
legteodav
force-pushed
the
issue-1733-e2e-test-withoutSync
branch
from
95f5554
to
9d4764e
Compare
JohannesDoberer
approved these changes
Jan 25, 2021
legteodav
force-pushed
the
issue-1733-e2e-test-withoutSync
branch
from
ad8a711
to
830716e
Compare
JohannesDoberer
added a commit
to JohannesDoberer/luigi
that referenced
this pull request
Feb 2, 2021
* master: travis slack integration update Update FD Styles to v.14 in E2E App (SAP#1817) Update Core fundamental styles from v.11 to v.14 (SAP#1805) Update fiddle version to 1.8.1 (SAP#1843) Move user settings config to an own section (SAP#1833) merging with master (SAP#1744) Release v1.8.1 (SAP#1851) fixed id_token only oidc flow (SAP#1840) Removing spinner background (SAP#1849) Wrong release tag for nightly in ng support lib SAP#1844 (SAP#1847) Fixing publishing problem (SAP#1844) Fixing CheckMark issue (SAP#1822) fix query param subscriptions issue (SAP#1839) # Conflicts: # core/src/UserSettingsDialog.html # core/src/UserSettingsEditor.html # test/e2e-test-application/src/luigi-config/extended/settings.js
Merged
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a e2e test for "withoutSync()" bug fix
Related issue(s)
Fixes #1733