Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move user settings config to an own section #1833

Merged
merged 11 commits into from
Jan 29, 2021
Merged

Move user settings config to an own section #1833

merged 11 commits into from
Jan 29, 2021

Conversation

JohannesDoberer
Copy link
Contributor

Fixes #1812

@JohannesDoberer JohannesDoberer added enhancement New feature or request refactoring Something needs to be refactored in a separate task labels Jan 24, 2021
@JohannesDoberer JohannesDoberer added this to the Sprint 16 milestone Jan 24, 2021
@JohannesDoberer
Copy link
Contributor Author

Docu will be fixed in #1818

@stanleychh stanleychh self-assigned this Jan 25, 2021
@UlianaMunich UlianaMunich self-assigned this Jan 25, 2021
@stanleychh
Copy link
Contributor

stanleychh commented Jan 25, 2021 •
edited
Loading

There are few terms use usersettings. I would suggest change them to userSettings. With the camel case.

UlianaMunich
UlianaMunich approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@UlianaMunich UlianaMunich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohannesDoberer JohannesDoberer merged commit b23970f into SAP:master Jan 29, 2021
@JohannesDoberer JohannesDoberer deleted the move-usersettings-config-and-docu branch January 29, 2021 09:11
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Feb 2, 2021
@JohannesDoberer
Merge branch 'master' into Remove-header-of-user-settings-dialog
8afcb19 
* master:
  travis slack integration update
  Update FD Styles to v.14 in E2E App (SAP#1817)
  Update Core fundamental styles from v.11 to v.14 (SAP#1805)
  Update fiddle version to 1.8.1 (SAP#1843)
  Move user settings config to an own section (SAP#1833)
  merging with master (SAP#1744)
  Release v1.8.1 (SAP#1851)
  fixed id_token only oidc flow (SAP#1840)
  Removing spinner background (SAP#1849)
  Wrong release tag for nightly in ng support lib  SAP#1844 (SAP#1847)
  Fixing publishing problem (SAP#1844)
  Fixing CheckMark issue (SAP#1822)
  fix query param subscriptions issue (SAP#1839)

# Conflicts:
#	core/src/UserSettingsDialog.html
#	core/src/UserSettingsEditor.html
#	test/e2e-test-application/src/luigi-config/extended/settings.js
@JohannesDoberer JohannesDoberer mentioned this pull request Feb 5, 2021
Merged
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@JohannesDoberer
Move user settings config to an own section (SAP#1833)
83e6293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UlianaMunich UlianaMunich UlianaMunich approved these changes

@stanleychh stanleychh stanleychh approved these changes

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@legteodav legteodav Awaiting requested review from legteodav

@maxmarkus maxmarkus Awaiting requested review from maxmarkus

@ndricimrr ndricimrr Awaiting requested review from ndricimrr ndricimrr is a code owner

Assignees

@UlianaMunich UlianaMunich

@stanleychh stanleychh

Labels
enhancement New feature or request refactoring Something needs to be refactored in a separate task
Projects
None yet
Milestone
Sprint 16
Development

Successfully merging this pull request may close these issues.

Move docu + configuration for user settings
3 participants
@JohannesDoberer @stanleychh @UlianaMunich