Context Switcher in top navigation #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxmarkus
added
enhancement
maxmarkus
requested review from
antiheld,
bszwarc,
dariadomagala-sap,
hardl,
jesusreal,
kazydek,
klaudiagrz,
kwiatekus,
parostatkiem-zz,
pekura,
tomekpapiernik and
y-kkamil
as code owners
jesusreal
reviewed
Nov 2, 2018
| config.parentNodePath = `${config.parentNodePath}/`; | ||
| } | ||
| } | ||
| if (!config.parentNodePath) { |
There was a problem hiding this comment.
Maybe you can use here just else instead of if (!config.parentNodePath)
jesusreal
reviewed
Nov 2, 2018
| const hasNoDynamicPathSegment = | ||
| config.parentNodePath.split('/').filter(p => p.startsWith(':')) | ||
| .length === 0; | ||
| if (hasNoDynamicPathSegment && !config.parentNodePath.endsWith('/')) { |
There was a problem hiding this comment.
Why do we have to add the final / only if there is no dynamic path segment?
jesusreal
reviewed
Nov 2, 2018
| }, | ||
| data() { | ||
| return { | ||
| dropDownStates: {}, |
There was a problem hiding this comment.
It would be nice to have an initialisation of all keys here, I see above we are setting some other keys on component creation.
jesusreal
reviewed
Nov 2, 2018
docs/navigation-configuration.md
Outdated
| - **position** is optional. Defines the action element position. Can be `top` or `bottom`. Defaults to `top` | ||
| - **link** is optional. Defines an absolute Link to a **node**. | ||
| - **clickHandler** specifies a function and is executed on click and should return a boolean. If it returns `true`, **link** is opened afterwards. | ||
| - **fallbackLabelResolver** specifies a function that is executed to fetch a context element label if **options** are not yet loaded or **label** is not defined. |
There was a problem hiding this comment.
Maybe I am missing something, since I don't understand why are we using the fallbackLabelResolver if 'options are not yet loaded', since this function is not responsible for setting the pathValue field for options.
… into feature/context-switcher
This reverts commit 86ba769.
…us/luigi into feature/context-switcher
… into feature/context-switcher
|
Fixes now also #193 |
… into feature/context-switcher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the possibility to show a dropdown with a list of links that can be used to enter a contextual path, eg. environments. Typically used in combination with a dynamic node, to be able to enter also hidden contexts.