-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Context Switcher in top navigation #190
Changes from 9 commits
d8cffc8
3794c6e
49e2946
a5d34ad
e8e0405
c4e4d57
35be633
e25b3fe
be143f3
119cac2
0a83dd7
b14f8bb
4ca4667
bc8a934
f39cd4c
c0e1682
f1414a7
065ae8f
3bd455d
cd56d94
c4cfbd2
e524ded
02135b5
3811923
22ce442
b9278e3
4c92bfd
714a701
cf4a7ca
c11acf2
d91e8a9
4146380
eed353c
8f44440
3bb30e2
24778fc
fe12527
3f78c84
9a964e3
2fb3152
ef3d82a
86ba769
b0e0ff5
64f50eb
c56f1df
a1eab3c
c1505f4
a919848
ff364cb
6509c2e
eba3353
28627c9
01c6c75
b752d42
dcce6ef
91bb21c
aced0dd
84a0672
4a96631
6ed4a1e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,7 @@ | |
<html> | ||
<head> | ||
<title>Luigi</title> | ||
<link rel='stylesheet' href='/luigi-core/fundamental-ui/fundamental-ui.min.css'> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it is a good move to import fundamental-ui this way, and in the future consolidate it inside luigi.css. Removes complexity regarding the usage of fundamental-ui. Awesome! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, I also think we can get rid of all imports then and have less pain in the future. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's a breaking change if we would remove it from core and expect that user would import it himself. IF we want to do that, then it would have to be well documented. |
||
<link rel='stylesheet' href='/luigi-core/luigi.css'> | ||
</head> | ||
<body> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason while we commented this code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to save space in the top navi, I am removing the code completely.