Strip query params in linkmanager navigate #2393
Merged
+41
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohannesDoberer
added
bug
JohannesDoberer
requested review from
alexandra-simeonova,
hardl,
ndricimrr,
rafalgamon,
stanleychh,
UlianaMunich and
wdoberschuetz
as code owners
…arams from client
…om:JohannesDoberer/luigi into strip-query-params-in-linkmanager-navigate # Bitte geben Sie eine Commit-Beschreibung ein, um zu erklären, warum dieser # Merge erforderlich ist, insbesondere wenn es einen aktualisierten # Upstream-Branch mit einem Thema-Branch zusammenführt. # # Zeilen, die mit '#' beginnen, werden ignoriert, # und eine leere Beschreibung bricht den Commit ab.
…om:JohannesDoberer/luigi into strip-query-params-in-linkmanager-navigate
hardl
previously requested changes
Dec 9, 2021
stanleychh
reviewed
Dec 15, 2021
…om:JohannesDoberer/luigi into strip-query-params-in-linkmanager-navigate
|
Let's move this forward. |
stanleychh
approved these changes
Dec 16, 2021
JohannesDoberer
deleted the
strip-query-params-in-linkmanager-navigate
branch
Merged
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2387