Strip query params in linkmanager navigate

client/src/linkManager.js

@@ -73,7 +73,6 @@ export class linkManager extends LuigiClientBase {
       console.warn('Navigation with an absolute path prevented.');
       return;
     }
-
     const navigationOpenMsg = {
       msg: 'luigi.navigation.open',
       sessionId: sessionId,

core/src/App.html

@@ -1348,16 +1348,19 @@
 
       if ('luigi.navigation.open' === e.data.msg) {
         isNavigateBack = false;
-
         const srcNode = isSpecialIframe ? iframe.luigi.currentNode : undefined;
         const srcPathParams = isSpecialIframe ? iframe.luigi.pathParams : undefined;
-
-        if (e.data.params.newTab) {
-          let path = buildPath(e.data.params, srcNode, srcPathParams);
+        const params = e.data.params;
+        const { intent, newTab, modal, splitView, drawer, withoutSync } = params;
+        if (e.source !== window && !intent && params.link) {
+          params.link = params.link.split('?')[0];
+        }
+        if (newTab) {
+          let path = buildPath(params, srcNode, srcPathParams);
           path = GenericHelpers.addLeadingSlash(path);
           openViewInNewTab(path);
-        } else if (e.data.params.modal !== undefined) {
-          let path = buildPath(e.data.params, srcNode, srcPathParams);
+        } else if (modal !== undefined) {
+          let path = buildPath(params, srcNode, srcPathParams);
           path = GenericHelpers.addLeadingSlash(path);
           const pathExist = await pathExists(path);
           path = await RoutingHelpers.handlePageNotFoundAndRetrieveRedirectPath(
@@ -1370,9 +1373,9 @@
           }
           contentNode = node;
           resetMicrofrontendModalData();
-          openViewInModal(path, e.data.params.modal === true ? {} : e.data.params.modal);
-        } else if (e.data.params.splitView !== undefined) {
-          let path = buildPath(e.data.params, srcNode, srcPathParams);
+          openViewInModal(path, modal === true ? {} : modal);
+        } else if (splitView !== undefined) {
+          let path = buildPath(params, srcNode, srcPathParams);
           path = GenericHelpers.addLeadingSlash(path);
           const pathExist = await pathExists(path);
           path = await RoutingHelpers.handlePageNotFoundAndRetrieveRedirectPath(
@@ -1384,9 +1387,9 @@
             return;
           }
           contentNode = node;
-          openSplitView(path, e.data.params.splitView);
-        } else if (e.data.params.drawer !== undefined) {
-          let path = buildPath(e.data.params, srcNode, srcPathParams);
+          openSplitView(path, splitView);
+        } else if (drawer !== undefined) {
+          let path = buildPath(params, srcNode, srcPathParams);
           path = GenericHelpers.addLeadingSlash(path);
           const pathExist = await pathExists(path);
           path = await RoutingHelpers.handlePageNotFoundAndRetrieveRedirectPath(
@@ -1399,11 +1402,11 @@
           }
           contentNode = node;
           resetMicrofrontendDrawerData();
-          e.data.params.drawer.isDrawer = true;
-          openViewInDrawer(path, e.data.params.drawer);
+          drawer.isDrawer = true;
+          openViewInDrawer(path, drawer);
         } else {
           getUnsavedChangesModalPromise().then(() => {
-            isNavigationSyncEnabled = !e.data.params.withoutSync;
+            isNavigationSyncEnabled = !withoutSync;
             handleNavigation(e.data, config, srcNode, srcPathParams);
             closeModal();
             closeSplitView();
@@ -1593,6 +1596,8 @@
             data,
             keepBrowserHistory
           );
+        } else {
+          console.warn('No client permissions to add url parameter for this node.');
         }
       }
 

core/src/services/routing.js

@@ -60,16 +60,18 @@ class RoutingClass {
     const preserveQueryParams = LuigiConfig.getConfigValue('routing.preserveQueryParams');
     let url = new URL(location.href);
     route = preserveQueryParams ? RoutingHelpers.composeSearchParamsToRoute(route) : route;
-    hashRouting ? (url.hash = route) : (url.pathname = route);
+    if (hashRouting) {
+      url.hash = route;
+    }
 
     const chosenHistoryMethod = pushState ? 'pushState' : 'replaceState';
     const method = LuigiConfig.getConfigValue('routing.disableBrowserHistory') ? 'replaceState' : chosenHistoryMethod;
     window.history[method](
       {
-        path: hashRouting ? url.hash : decodeURIComponent(url.pathname)
+        path: hashRouting ? url.hash : route
       },
       '',
-      hashRouting ? url.hash : decodeURIComponent(url.pathname)
+      hashRouting ? url.hash : route
     );
 
     // https://developer.mozilla.org/en-US/docs/Web/API/CustomEvent#Browser_compatibility

core/src/utilities/helpers/routing-helpers.js

@@ -45,6 +45,7 @@ class RoutingHelpersClass {
   }
 
   parseParams(paramsString) {
+    if (!paramsString) return {};
     const result = {};
     const viewParamString = paramsString;
     const pairs = viewParamString ? viewParamString.split('&') : null;
@@ -504,15 +505,24 @@ class RoutingHelpersClass {
   }
 
   addSearchParamsFromClient(currentNode, searchParams, keepBrowserHistory) {
+    const localSearchParams = { ...searchParams };
+    if (!GenericHelpers.isObject(localSearchParams)) {
+      return;
+    }
+    Object.keys(localSearchParams).forEach(key => {
+      localSearchParams[key] = encodeURIComponent(localSearchParams[key]);
+    });
     if (currentNode && currentNode.clientPermissions && currentNode.clientPermissions.urlParameters) {
       const filteredObj = {};
       Object.keys(currentNode.clientPermissions.urlParameters).forEach(key => {
-        if (key in searchParams && currentNode.clientPermissions.urlParameters[key].write === true) {
-          filteredObj[key] = searchParams[key];
-        } else {
-          console.warn(`No permission to add "${key}" to the url`);
+        if (key in localSearchParams && currentNode.clientPermissions.urlParameters[key].write === true) {
+          filteredObj[key] = localSearchParams[key];
+          delete localSearchParams[key];
         }
       });
+      for (const key in localSearchParams) {
+        console.warn(`No permission to add the search param "${key}" to the url`);
+      }
       if (Object.keys(filteredObj).length > 0) {
         LuigiRouting.addSearchParams(filteredObj, keepBrowserHistory);
       }

core/test/utilities/helpers/routing-helpers.spec.js

@@ -678,7 +678,7 @@ describe('Routing-helpers', () => {
     it('Client can not write luigi url parameter', () => {
       currentNode.clientPermissions.urlParameters.luigi.write = false;
       RoutingHelpers.addSearchParamsFromClient(currentNode, { luigi: 'rocks', test: 'tets' });
-      sinon.assert.calledWith(console.warn, 'No permission to add "luigi" to the url');
+      sinon.assert.calledWith(console.warn, 'No permission to add the search param "luigi" to the url');
     });
     it('Client can only write specific url parameter', () => {
       currentNode.clientPermissions.urlParameters = {
@@ -693,7 +693,7 @@ describe('Routing-helpers', () => {
       };
       RoutingHelpers.addSearchParamsFromClient(currentNode, { luigi: 'rocks', test: 'tets' });
       sinon.assert.calledWith(LuigiRouting.addSearchParams, { test: 'tets' });
-      sinon.assert.calledWith(console.warn, 'No permission to add "luigi" to the url');
+      sinon.assert.calledWith(console.warn, 'No permission to add the search param "luigi" to the url');
     });
   });
 

test/e2e-test-application/src/app/project/project.component.html

@@ -309,19 +309,6 @@ <h3 class="fd-layout-panel__title">Navigate</h3>
               data="linkManager().navigate('users/groups/stakeholders')"
             ></app-code-snippet>
           </li>
-          <li class="fd-list__item">
-            <a
-              href="javascript:void(0)"
-              class="fd-link"
-              (click)="
-                linkManager().navigate('/projects/pr1/settings?ft=ft1')
-              "
-              >FeatureToggle</a
-            >
-            <app-code-snippet
-              data="linkManager().navigate('/projects/pr1/settings?ft=ft1')"
-            ></app-code-snippet>
-          </li>
           <li class="fd-list__item">
             <a
               href="javascript:void(0)"
@@ -388,24 +375,6 @@ <h3 class="fd-layout-panel__title">Navigate</h3>
             >
             </app-code-snippet>
           </li>
-          <li class="fd-list__item">
-            <a
-              href="javascript:void(0)"
-              class="fd-link"
-              (click)="
-                linkManager()
-                  .fromClosestContext()
-                  .withParams({ feature: 'toggle' })
-                  .navigate('settings_ft?ft=ft1')
-              "
-            >
-              project to settings with params (foo=bar) and FeatureToggle</a
-            >
-            <app-code-snippet
-              data="linkManager().fromClosestContext().withParams({feature: 'toggle'}).navigate('settings_ft?ft=ft1')"
-            >
-            </app-code-snippet>
-          </li>
           <li class="fd-list__item">
             <a
               href="javascript:void(0)"