Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write updated modal settings to url #3339

Merged
merged 4 commits into from
Jul 7, 2023
Merged

Write updated modal settings to url #3339

merged 4 commits into from
Jul 7, 2023

Conversation

JohannesDoberer
Copy link
Contributor

Fixes #3338

@JohannesDoberer JohannesDoberer added the enhancement New feature or request label Jun 29, 2023
@JohannesDoberer JohannesDoberer added the documentation documentation tasks label Jun 29, 2023
alexandra-simeonova
alexandra-simeonova reviewed Jun 30, 2023
View reviewed changes
client/src/linkManager.js Outdated Show resolved Hide resolved
client/src/linkManager.js Outdated Show resolved Hide resolved
hardl
hardl requested changes Jun 30, 2023
View reviewed changes
core/src/Modal.svelte Outdated Show resolved Hide resolved
hardl
hardl approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@hardl hardl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohannesDoberer JohannesDoberer merged commit 3f1da15 into main Jul 7, 2023
8 checks passed
@JohannesDoberer JohannesDoberer deleted the Write-updated-modal-settings-to-url branch July 7, 2023 09:55
@JohannesDoberer JohannesDoberer mentioned this pull request Jul 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandra-simeonova alexandra-simeonova alexandra-simeonova left review comments

@hardl hardl hardl approved these changes

@ndricimrr ndricimrr Awaiting requested review from ndricimrr ndricimrr is a code owner

Assignees
No one assigned
Labels
documentation documentation tasks enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[low prio] incorrectly rendered rounding when setting the size via updateLuigiModalSettings
3 participants
@JohannesDoberer @hardl @alexandra-simeonova