Product Switcher documentation and configurable label and icon #703
+76
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maxmarkus
commented
Jul 30, 2019
maxmarkus
commented
- label and icon are configurable
- adds documentation
maxmarkus
requested review from
bszwarc,
hardl,
jesusreal,
JohannesDoberer,
kazydek,
marynaKhromova,
mmitoraj,
pekura and
tomekpapiernik
as code owners
bszwarc
suggested changes
Jul 31, 2019
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
…uigi into 698-configurable-my-products
…uigi into 698-configurable-my-products
bszwarc
approved these changes
Jul 31, 2019
…uigi into 698-configurable-my-products
| productSwitcher = { | ||
| label: 'My Products', |
There was a problem hiding this comment.
If there is a empty object productSwitcher ={} we get the following view on mobile.
There was a problem hiding this comment.
Thanks, I have added the default label My Products. Is also required for backwards compatibility.
…uigi into 698-configurable-my-products
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
Added product switcher configurable icon and label, documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.