-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Product Switcher documentation and configurable label and icon #703
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
b670a99
added product switcher configurable icon and label, documentation
maxmarkus 495c8b9
docu update, similar to profile
maxmarkus 4af3e36
productSwitcher demo config object
maxmarkus ccb3e59
Apply suggestions from code review
maxmarkus ee3be3d
Merge branch '698-configurable-my-products' of github.com:maxmarkus/l…
maxmarkus d7a83a0
Merge branch 'master' into 698-configurable-my-products
maxmarkus 0408656
Merge branch '698-configurable-my-products' of github.com:maxmarkus/l…
maxmarkus e376df7
Merge branch 'master' into 698-configurable-my-products
maxmarkus 7e7f662
Merge branch '698-configurable-my-products' of github.com:maxmarkus/l…
maxmarkus 5f3ed4e
defaults for productswitcher
maxmarkus fb927aa
Merge branch 'master' into 698-configurable-my-products
maxmarkus b105a22
Merge branch '698-configurable-my-products' of github.com:maxmarkus/l…
maxmarkus 1be30cb
applied defaults to second place, refactored to have defaults in a he…
maxmarkus 7c140f3
Merge branch 'master' into 698-configurable-my-products
maxmarkus fac3567
Merge branch 'master' into 698-configurable-my-products
maxmarkus 41842ad
Merge branch 'master' into 698-configurable-my-products
jesusreal e5d1c80
Merge branch 'master' into 698-configurable-my-products
jesusreal a6b2d3e
Merge branch 'master' into 698-configurable-my-products
maxmarkus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is a empty object
productSwitcher ={}
we get the following view on mobile.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I have added the default label My Products. Is also required for backwards compatibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍