-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Support ES2021 language features #692
Conversation
By upgrading espree to the latest version, ES2021 language features are now supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @codeworrior to approve
I have to make up my mind how to properly handle chained expressions. Our check for conditional expressions wants to detect whether a certain code is always executed (eager) or not (conditional). The following top level code
would eagerly depend on a/b/c. But
would not. This no longer can be declared statically. Within a ChainExpression.expression, the optional flag of the contained MemberExpressions has to be taken into account. If it is true, then the property part becomes conditional. Well, but to enable the new syntax elements, the change is both required and helpful. |
Thanks for the insights. I also thought about handling for the ChainExpression. What I forgot to mention: |
Reg. the gaps in espree.Syntax see eslint/js#532 (fixes eslint/js#531) I'm waiting for OSPO to approve the (C)CLA. |
@codeworrior, thanks for contributing to the ESLint project. Does this merge mean that UI5 Tooling 2.14.5 now supports the ES2021 language features? |
@pubmikeb this PR got merged into the As the espree update requires a higher node version, we are not able to port this into the v2.x codeline. |
By upgrading espree to the latest version, ES2021 language features
are now supported.
JIRA: CPOUI5FOUNDATION-363