-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Derive espree.Syntax from espree.VisitorKeys #532
Conversation
Hi @codeworrior!, thanks for the Pull Request The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.
To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page. Read more about contributing to ESLint here |
Sorry for not immediately signing the CLA. I have to clarify with my employer first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just want another set of eyes before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Waiting for CLA before merging.
Sorry for the delay. After my employer decided to sign the corporate CLA, we struggled a bit with the process and tooling, but now we're done. |
Thanks for contributing! |
Fixes #531.
If removing the
lib/ast-node-types.js
is regarded as an incompatible change, I can restore it and leave the cleanup up to you in one of the upcoming major releases. My assumption was that the module is rather an internal thing and not part of your APIs.