Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation about Build Extensibility #71

Merged
merged 1 commit into from
Dec 10, 2018
Merged

Add documentation about Build Extensibility #71

merged 1 commit into from
Dec 10, 2018

Conversation

devtomtom
Copy link
Member

@devtomtom devtomtom commented Dec 3, 2018 •
edited by RandomByte
Loading

@CLAassistant
Copy link

CLAassistant commented Dec 3, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Dec 3, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 311

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.765%
Totals Coverage Status
Change from base Build 305: 0.0%
Covered Lines: 297
Relevant Lines: 381
💛 - Coveralls

RandomByte
RandomByte requested changes Dec 3, 2018
View reviewed changes
Copy link
Member

@RandomByte RandomByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some quick feedback. Let's look into the details tomorrow

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/BuildExtensibility.md Outdated Show resolved Hide resolved
docs/BuildExtensibility.md Outdated Show resolved Hide resolved
RandomByte
RandomByte requested changes Dec 4, 2018
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/BuildExtensibility.md Outdated Show resolved Hide resolved
docs/BuildExtensibility.md Outdated Show resolved Hide resolved
docs/BuildExtensibility.md Outdated Show resolved Hide resolved
docs/BuildExtensibility.md Outdated Show resolved Hide resolved
docs/BuildExtensibility.md Outdated Show resolved Hide resolved
docs/BuildExtensibility.md Outdated Show resolved Hide resolved
@devtomtom devtomtom force-pushed the add-documentation-build-extensibility branch from 598d41f to 1850dab Compare December 4, 2018 15:03
RandomByte
RandomByte reviewed Dec 4, 2018
View reviewed changes
Copy link
Member

@RandomByte RandomByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me, but let's wait for @SabineLoss`s feedback

@RandomByte RandomByte requested a review from SabineLoss December 7, 2018 13:34
@RandomByte
Copy link
Member

As discussed, Sabine will review the complete readme after this PR got merged.

@RandomByte RandomByte merged commit 97e96f3 into master Dec 10, 2018
@RandomByte RandomByte deleted the add-documentation-build-extensibility branch December 10, 2018 13:07
@RandomByte RandomByte mentioned this pull request Feb 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thodd Thodd Thodd left review comments

@RandomByte RandomByte RandomByte approved these changes

@SabineLoss SabineLoss Awaiting requested review from SabineLoss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devtomtom @CLAassistant @coveralls @RandomByte @Thodd