Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] 0004 Simple Build Extensibility #54

Merged
merged 3 commits into from
Mar 27, 2019
Merged

[RFC] 0004 Simple Build Extensibility #54

merged 3 commits into from
Mar 27, 2019

Conversation

RandomByte
Copy link
Member

@RandomByte RandomByte commented Aug 28, 2018 •
edited
Loading

Add a feature for basic customization of how a single UI5 project is being built.

Follow up of #4

@RandomByte RandomByte added the RFC Request for Comment (pull request) label Aug 28, 2018
@RandomByte RandomByte mentioned this pull request Aug 28, 2018
Open
@RandomByte
Copy link
Member Author

In addition to the beforeTask/afterTask options, should there be an option to filter on the project type?

This would allow to insert tasks for e.g. application-projects only.

CC: @petermuessig, @matz3

RandomByte added a commit to SAP/ui5-builder that referenced this pull request Nov 16, 2018
@RandomByte
[FEATURE] Task Extensibility: Add handling for custom task project
eaeea4a 
configuration

As per RFC0004: SAP/ui5-tooling#54
@RandomByte RandomByte mentioned this pull request Nov 16, 2018
Merged
RandomByte added a commit to SAP/ui5-project that referenced this pull request Nov 16, 2018
@RandomByte
[FEATURE] Task Extensibility: Add handling for task extensions
8faef7c 
As per RFC0004: SAP/ui5-tooling#54
@RandomByte RandomByte mentioned this pull request Nov 16, 2018
Merged
RandomByte added a commit to SAP/ui5-project that referenced this pull request Nov 16, 2018
@RandomByte
[FEATURE] Task Extensibility: Add handling for task extensions
467dd80 
As per RFC0004: SAP/ui5-tooling#54
RandomByte added a commit to SAP/ui5-project that referenced this pull request Nov 16, 2018
@RandomByte
[FEATURE] projectPreprocessor: Add handling for task extensions
3f56e6f 
As per RFC0004: SAP/ui5-tooling#54
RandomByte added a commit to SAP/ui5-builder that referenced this pull request Nov 16, 2018
@RandomByte
[FEATURE] Builder: Add handling for custom task configurations
f882676 
As per RFC0004: SAP/ui5-tooling#54
RandomByte added a commit to SAP/ui5-project that referenced this pull request Nov 16, 2018
@RandomByte
[FEATURE] projectPreprocessor: Add handling for task extensions
8c5dc72 
As per RFC0004: SAP/ui5-tooling#54
Depends on SAP/ui5-builder#106
@RandomByte
Copy link
Member Author

Actually, never mind. It obviously only runs in the project it has been configured in, which has exactly one type 😅

@RandomByte
Copy link
Member Author

Test implementation: RandomByte/openui5-sample-app#1

@RandomByte
Fix yaml and move task implementation into sub-directory
9b34c74 
Having custom taks in dedicated directories might be the more common approach
RandomByte added a commit to SAP/ui5-project that referenced this pull request Nov 16, 2018
@RandomByte
[FEATURE] projectPreprocessor: Add handling for task extensions
34e2237 
As per RFC0004: SAP/ui5-tooling#54
Depends on SAP/ui5-builder#106
RandomByte added a commit to SAP/ui5-builder that referenced this pull request Nov 16, 2018
@RandomByte
[FEATURE] Builder: Add handling for custom task configurations
9b4ae00 
As per RFC0004: SAP/ui5-tooling#54
RandomByte added a commit to SAP/ui5-project that referenced this pull request Nov 17, 2018
@RandomByte
[FEATURE] projectPreprocessor: Add handling for task extensions
c110515 
As per RFC0004: SAP/ui5-tooling#54
Depends on SAP/ui5-builder#106
RandomByte added a commit to SAP/ui5-project that referenced this pull request Nov 17, 2018
@RandomByte
[FEATURE] projectPreprocessor: Add handling for task extensions
0722865 
As per RFC0004: SAP/ui5-tooling#54
Depends on SAP/ui5-builder#106
@RandomByte
Copy link
Member Author

This RFC got implemented with SAP/ui5-builder#106 and SAP/ui5-project#64

This can be tested with UI5 CLI v0.2.4.
Example setup: RandomByte/openui5-sample-app#1

Still missing: Updated documentation

@sebbi08
Copy link
Contributor

sebbi08 commented Nov 27, 2018

In addition to the beforeTask/afterTask options, should there be an option to filter on the project type?

This would allow to insert tasks for e.g. application-projects only.

CC: @petermuessig, @matz3

acctualy something like first/last would be nice so that certen tasks run at first / last always

@devtomtom devtomtom mentioned this pull request Dec 5, 2018
Merged
tobiasso85 pushed a commit to SAP/ui5-builder that referenced this pull request Dec 17, 2018
@RandomByte @tobiasso85
[FEATURE] Builder: Add handling for custom task configurations
f0d4429 
As per RFC0004: SAP/ui5-tooling#54
@RandomByte RandomByte mentioned this pull request Dec 19, 2018
Closed
21 tasks
@RandomByte
Copy link
Member Author

Documentation got merged with SAP/ui5-project#71. Available here: https://github.com/SAP/ui5-project/blob/master/docs/BuildExtensibility.md

@RandomByte
Copy link
Member Author

@sebbi08 I created https://github.com/SAP/ui5-builder/issues/179 to keep track of your suggestion

@RandomByte RandomByte requested a review from matz3 February 15, 2019 16:19
@RandomByte
Copy link
Member Author

@matz3 you think this is ready to be merged?

@RandomByte RandomByte merged commit 56aa167 into master Mar 27, 2019
@RandomByte RandomByte deleted the rfc-simple-build-extensibility branch March 27, 2019 09:49
@matz3 matz3 mentioned this pull request May 14, 2019
Closed
6 tasks
@RandomByte RandomByte mentioned this pull request Nov 20, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matz3 matz3 matz3 approved these changes

Assignees
No one assigned
Labels
RFC Request for Comment (pull request)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RandomByte @sebbi08 @matz3