-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle package-specifier spacing #197
Conversation
… into cwa/debug-ci-check-dependencies
Print out all steps if debug=true for workflow.
Codecov Report
@@ Coverage Diff @@
## main #197 +/- ##
==========================================
+ Coverage 71.42% 72.09% +0.66%
==========================================
Files 9 9
Lines 567 577 +10
==========================================
+ Hits 405 416 +11
+ Misses 162 161 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I've made a couple of comments.
Multiple version specifiers are not reliably supported. Follow issue #141 for updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thank you very much!
If there is no space between the package name and the version specifiers, the
pyproject.toml
file would not be updated. This has been remedied.Fixes #195.
In addition, this PR adds a
debug
input value for the CI - Check dependencies callable worfklow, which will utilize the new--verbose
option for theupdate-deps
task.