Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle package-specifier spacing #197

Merged
merged 21 commits into from
Oct 25, 2023
Merged

Conversation

CasperWA
Copy link
Collaborator

If there is no space between the package name and the version specifiers, the pyproject.toml file would not be updated. This has been remedied.

Fixes #195.

In addition, this PR adds a debug input value for the CI - Check dependencies callable worfklow, which will utilize the new --verbose option for the update-deps task.

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #197 (2905184) into main (3f0821e) will increase coverage by 0.66%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #197      +/-   ##
==========================================
+ Coverage   71.42%   72.09%   +0.66%     
==========================================
  Files           9        9              
  Lines         567      577      +10     
==========================================
+ Hits          405      416      +11     
+ Misses        162      161       -1     
Files Coverage Δ
ci_cd/tasks/update_deps.py 82.69% <100.00%> (+1.37%) ⬆️

@CasperWA CasperWA marked this pull request as ready for review October 23, 2023 10:04
Copy link
Contributor

@ajeklund ajeklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I've made a couple of comments.

ci_cd/tasks/update_deps.py Show resolved Hide resolved
tests/tasks/test_update_deps.py Show resolved Hide resolved
tests/tasks/test_update_deps.py Show resolved Hide resolved
Copy link
Contributor

@ajeklund ajeklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion.

tests/tasks/test_update_deps.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ajeklund ajeklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thank you very much!

@CasperWA CasperWA merged commit a33be22 into main Oct 25, 2023
18 checks passed
@CasperWA CasperWA deleted the cwa/debug-ci-check-dependencies branch October 25, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A PR is not opened for CI - Check dependencies
2 participants