Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure version dependency ranges are respected when updating #141

Closed
CasperWA opened this issue Apr 18, 2023 · 0 comments · Fixed by #190
Closed

Ensure version dependency ranges are respected when updating #141

CasperWA opened this issue Apr 18, 2023 · 0 comments · Fixed by #190
Assignees
@CasperWA
Labels
bug Something isn't working GH Workflows Issue/PR related to the callable workflows priority/high High priority issue/PR

Comments

@CasperWA
Copy link
Collaborator

Dependency version ranges are still not properly respected.

For example if >=1.0.0,<2 is specified, but the latest version is 2.3.1, then the result (with no ignore rules) will be >=2.3.1,<2, which makes no sense.
@CasperWA CasperWA added bug Something isn't working GH Workflows Issue/PR related to the callable workflows priority/high High priority issue/PR labels Apr 18, 2023
@CasperWA CasperWA mentioned this issue Apr 18, 2023
Merged
@CasperWA CasperWA self-assigned this Sep 13, 2023
@CasperWA CasperWA mentioned this issue Sep 13, 2023
Closed
3 tasks
@daniel-sintef daniel-sintef mentioned this issue Oct 6, 2023
Merged
8 tasks
@CasperWA CasperWA mentioned this issue Oct 9, 2023
Merged
2 tasks
CasperWA added a commit that referenced this issue Oct 25, 2023
@CasperWA
Avoid name3 in test
3878d3f 
Multiple version specifiers are not reliably supported. Follow
issue #141 for updates.
CasperWA added a commit that referenced this issue Oct 25, 2023
@CasperWA @ajeklund
Handle package-specifier spacing (#197)
a33be22 
Use the spacing between package name and specifier.

New:
- Add `--verbose` option to update-deps.
- Add `debug` input for CI - Check dependencies.

Log sub-line input to update_file() in update_deps().

Update tests to include spacing issues.
Add test for the --verbose flag.

Add comments in test according to code review.
Avoid `name3` in test since multiple version specifiers are
not reliably supported. Follow  issue #141 for updates.
Explain change in `name2`.


Co-authored-by: Anders Eklund <anders.eklund@sintef.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CasperWA CasperWA

Labels
bug Something isn't working GH Workflows Issue/PR related to the callable workflows priority/high High priority issue/PR
Projects
None yet
Milestone
No milestone
1 participant
@CasperWA