-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update staging branch #299
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Related Issue Closes #254 ## Overall Este PR tem como objetivo alterar a forma como é feita a busca de itens na tela de abrigo para evitar a duplicação de itens. As alterações propostas incluem: - Remove o botão de cadastrar novo item no topo da página - Adiciona autocomplete para busca de itens - Adiciona opção de cadastrar novo item no autocomplete ## Screen recording https://github.com/SOS-RS/frontend/assets/8760873/74db3fa0-c45c-4b7a-afb2-d3d5279c0106
…ara "precisa com urgência" (#288) Relacionado à issue: #284 Ao rodar o lint, reparei que o projeto tinha 5 warnings, relacionados a `Separate Constants or Functions from Components`. antes: ![image](https://github.com/SOS-RS/frontend/assets/70142962/45bb57da-7f61-419c-ad00-c97dd6edcc75) depois: ![image](https://github.com/SOS-RS/frontend/assets/70142962/d91c2674-7a30-45c5-b515-9d971958fc78) _Indicates that Fast Refresh works best when a file only exports components. If you have constants or functions that are not part of the component, move them to a separate file._ Consegui resolver 4 deles (não tenho taaaanta experiência com forms, rs), então achei válido manter nesse PR, mas caso fuja do padrão esperado por vocês, posso remover e deixar esse PR focado no objetivo da issue relacionada. **PS:** <s>ainda preciso instalar o backend para verificar se preciso modificar algo relacionado a esta issue</s> (**_edit:_** não encontrei nada no backend).
rhuam
approved these changes
May 23, 2024
fagundesjg
added a commit
that referenced
this pull request
May 24, 2024
* fix/ add lucide icons to replace emojis so it works across all browsers * feat: added shelter category * setup shadcdn combobox * remove new item btn * add autocomplete with search * handle add new item * add clear feat * cleanup * cleanup * cleanup * fix imports * fix: new item keeps on when item selected * update text * add text above list * add initial filter to show only stored supplies * Add contributing * remove unused import * Resolves #284 * review * removes unusued session context * finishing * removes unusued functions * feat: added more contributors to about me page (#292) * feat: added hmac and obfuscate api module (#294) ---------
AlchemistByte
pushed a commit
to AlchemistByte/frontend
that referenced
this pull request
Jun 6, 2024
* fix/ add lucide icons to replace emojis so it works across all browsers * feat: added shelter category * setup shadcdn combobox * remove new item btn * add autocomplete with search * handle add new item * add clear feat * cleanup * cleanup * cleanup * fix imports * fix: new item keeps on when item selected * update text * add text above list * add initial filter to show only stored supplies * Add contributing * remove unused import * Resolves SOS-RS#284 * review * removes unusued session context * finishing * removes unusued functions * feat: added more contributors to about me page (SOS-RS#292) * feat: added hmac and obfuscate api module (SOS-RS#294) --------- Co-authored-by: andradeviniicius <viniciusdandrade01@gmail.com> Co-authored-by: Larissa Pissurno <larissapissurno@gmail.com> Co-authored-by: Giovanni Bassi <giggio@giggio.net> Co-authored-by: Vinicius Silveira <vinnysilveira09@gmail.com> Co-authored-by: rayanerocha07 <rayane.rocha07@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.