Skip to content

Commit

Permalink
Remove Gemfile.lock from template (facebook#33469)
Browse files Browse the repository at this point in the history
Summary:
For the same reason we don't keep a yarn.lock or Podfile.lock, we shouldn't be keeping a Gemfile.lock in the template. The user will generate this on his own pulling in the current dependencies with the constraints in Gemfile. No need to lock to a specific version.

cc barbieri (author of facebook#32303)
cc ravirajn22 (for raising the issue)

[iOS] [Fixed] - Remove Gemfile.lock from template

Pull Request resolved: facebook#33469

Test Plan: no test plan

Reviewed By: javache

Differential Revision: D35074105

Pulled By: cortinico

fbshipit-source-id: 47d1b92329f1d55d4a0adbacbc7e5e45f9d957e0
  • Loading branch information
danilobuerger authored and Saadnajmi committed Jan 14, 2023
1 parent 367d639 commit 47988ff
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 106 deletions.
6 changes: 2 additions & 4 deletions scripts/update-ruby.sh
Original file line number Diff line number Diff line change
Expand Up @@ -53,17 +53,15 @@ echo "$VERSION" > template/_ruby-version
sed_i -e "s/^\(ruby '\)[^']*\('.*\)$/\1$VERSION\2/" Gemfile
sed_i -e "s/^\(ruby '\)[^']*\('.*\)$/\1$VERSION\2/" template/Gemfile

rm -f Gemfile.lock template/Gemfile.lock
rm -f Gemfile.lock

export BUNDLE_APP_CONFIG="$ROOT/.bundle"
cp "$BUNDLE_APP_CONFIG/"* template/_bundle # sync!

bundle lock
(cd template && bundle lock)

git add \
.ruby-version \
Gemfile \
template/_ruby-version \
template/Gemfile \
template/Gemfile.lock
template/Gemfile
102 changes: 0 additions & 102 deletions template/Gemfile.lock

This file was deleted.

0 comments on commit 47988ff

Please sign in to comment.