Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Gemfile.lock from template #33469

Closed
wants to merge 1 commit into from

Conversation

danilobuerger
Copy link
Contributor

Summary

For the same reason we don't keep a yarn.lock or Podfile.lock, we shouldn't be keeping a Gemfile.lock in the template. The user will generate this on his own pulling in the current dependencies with the constraints in Gemfile. No need to lock to a specific version.

cc @barbieri (author of #32303)
cc @ravirajn22 (for raising the issue)

Changelog

[iOS] [Fixed] - Remove Gemfile.lock from template

Test Plan

no test plan

For the same reason we don't keep a yarn.lock or Podfile.lock, we shouldn't be keeping a Gemfile.lock in the template. The user will generate this on his own pulling in the current dependencies with the constraints in Gemfile. No need to lock to a specific version.
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Mar 23, 2022
@react-native-bot react-native-bot added Bug Platform: iOS iOS applications. labels Mar 23, 2022
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 743d070
Branch: main

@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,951,034 +0
android hermes armeabi-v7a 7,546,239 +0
android hermes x86 8,305,366 +0
android hermes x86_64 8,257,171 +0
android jsc arm64-v8a 9,619,637 +0
android jsc armeabi-v7a 8,599,257 +0
android jsc x86 9,570,057 +0
android jsc x86_64 10,165,993 +0

Base commit: 743d070
Branch: main

@cortinico
Copy link
Contributor

I suppose the CI failure is unrelated?

@danilobuerger
Copy link
Contributor Author

@cortinico I think its coming from a recent commit to main: 45e2941 If nobody is on it already, I could try fixing it in a separate pr?

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @danilobuerger in 1907bd3.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Mar 23, 2022
@danilobuerger danilobuerger deleted the gemfilelock branch March 23, 2022 12:15
@barbieri
Copy link
Contributor

sorry taking long, but looks good to me :-)

@cortinico
Copy link
Contributor

@cortinico I think its coming from a recent commit to main: 45e2941 If nobody is on it already, I could try fixing it in a separate pr?

I've realized it's a failure related to a missing version of react-native-codegen. I'm on it as this needs to be done internally, but thanks for offering to look into this @danilobuerger 🙏

Saadnajmi pushed a commit to Saadnajmi/react-native-macos that referenced this pull request Jan 15, 2023
Summary:
For the same reason we don't keep a yarn.lock or Podfile.lock, we shouldn't be keeping a Gemfile.lock in the template. The user will generate this on his own pulling in the current dependencies with the constraints in Gemfile. No need to lock to a specific version.

cc barbieri (author of facebook#32303)
cc ravirajn22 (for raising the issue)

[iOS] [Fixed] - Remove Gemfile.lock from template

Pull Request resolved: facebook#33469

Test Plan: no test plan

Reviewed By: javache

Differential Revision: D35074105

Pulled By: cortinico

fbshipit-source-id: 47d1b92329f1d55d4a0adbacbc7e5e45f9d957e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: iOS iOS applications. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants