-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Gemfile.lock from template #33469
Conversation
For the same reason we don't keep a yarn.lock or Podfile.lock, we shouldn't be keeping a Gemfile.lock in the template. The user will generate this on his own pulling in the current dependencies with the constraints in Gemfile. No need to lock to a specific version.
Base commit: 743d070 |
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 743d070 |
I suppose the CI failure is unrelated? |
@cortinico I think its coming from a recent commit to main: 45e2941 If nobody is on it already, I could try fixing it in a separate pr? |
This pull request was successfully merged by @danilobuerger in 1907bd3. When will my fix make it into a release? | Upcoming Releases |
sorry taking long, but looks good to me :-) |
I've realized it's a failure related to a missing version of |
Summary: For the same reason we don't keep a yarn.lock or Podfile.lock, we shouldn't be keeping a Gemfile.lock in the template. The user will generate this on his own pulling in the current dependencies with the constraints in Gemfile. No need to lock to a specific version. cc barbieri (author of facebook#32303) cc ravirajn22 (for raising the issue) [iOS] [Fixed] - Remove Gemfile.lock from template Pull Request resolved: facebook#33469 Test Plan: no test plan Reviewed By: javache Differential Revision: D35074105 Pulled By: cortinico fbshipit-source-id: 47d1b92329f1d55d4a0adbacbc7e5e45f9d957e0
Summary
For the same reason we don't keep a yarn.lock or Podfile.lock, we shouldn't be keeping a Gemfile.lock in the template. The user will generate this on his own pulling in the current dependencies with the constraints in Gemfile. No need to lock to a specific version.
cc @barbieri (author of #32303)
cc @ravirajn22 (for raising the issue)
Changelog
[iOS] [Fixed] - Remove Gemfile.lock from template
Test Plan
no test plan