Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create table from file #145

Closed
lars-reimann opened this issue Nov 9, 2022 · 0 comments · Fixed by #164
Closed

Create table from file #145

lars-reimann opened this issue Nov 9, 2022 · 0 comments · Fixed by #164
Assignees
@WinPlay02 @Gerhardsa0
Labels
enhancement 💡 New feature or request

Comments

@lars-reimann
Copy link
Member

lars-reimann commented Nov 9, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe

Usually, a user doesn't programmatically create tables but instead already has the data stored in some file.

Desired solution

There should be a function to read data into a table (#144) from various sources. For now, the following formats suffice:

  • JSON
  • CSV

The functionality should be available as static methods on the Table class. The methods should be called:

  • Table.from_json
  • Table.from_csv

Both functions should accept a file path as a parameter to select the file to read. The file path should be given as a string.
@lars-reimann lars-reimann added the enhancement 💡 New feature or request label Nov 9, 2022
@lars-reimann lars-reimann moved this to Backlog in Safe-DS Nov 9, 2022
@lars-reimann lars-reimann moved this from Backlog to To do in Safe-DS Nov 11, 2022
@WinPlay02 WinPlay02 mentioned this issue Nov 11, 2022
Merged
@WinPlay02 WinPlay02 linked a pull request Nov 11, 2022 that will close this issue
feat: Create table from file: read_csv and read_json #164
Merged
@WinPlay02 WinPlay02 moved this from To do to Ready for review in Safe-DS Nov 11, 2022
lars-reimann added a commit that referenced this issue Nov 16, 2022
@WinPlay02 @lars-reimann
feat: Create table from file: read_csv and read_json (#164)
1697690 
Closes #145.

### Summary of Changes

Added functions: read_csv and read_json
Added Tests: valid and invalid inputs

Co-authored-by: WinPlay02 <WinPlay02@users.noreply.github.com>
Co-authored-by: Lars Reimann <mail@larsreimann.com>
Co-authored-by: lars-reimann <lars-reimann@users.noreply.github.com>
Repository owner moved this from Ready for review to ✔️ Done in Safe-DS Nov 16, 2022
Gerhardsa0 pushed a commit that referenced this issue Dec 9, 2022
@WinPlay02 @lars-reimann @Gerhardsa0
feat: Create table from file: read_csv and read_json (#164)
e99baa1 
Closes #145.

### Summary of Changes

Added functions: read_csv and read_json
Added Tests: valid and invalid inputs

Co-authored-by: WinPlay02 <WinPlay02@users.noreply.github.com>
Co-authored-by: Lars Reimann <mail@larsreimann.com>
Co-authored-by: lars-reimann <lars-reimann@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WinPlay02 WinPlay02

@Gerhardsa0 Gerhardsa0

Labels
enhancement 💡 New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Create table from file: read_csv and read_json Safe-DS/DSL
3 participants
@lars-reimann @WinPlay02 @Gerhardsa0