Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Create table from file: read_csv and read_json #164

Merged
merged 22 commits into from
Nov 16, 2022
Merged

feat: Create table from file: read_csv and read_json #164

merged 22 commits into from
Nov 16, 2022

Conversation

WinPlay02
Copy link
Contributor

Closes #145.

Summary of Changes

Added functions: read_csv and read_json
Added Tests: valid and invalid inputs

@WinPlay02 WinPlay02 linked an issue Nov 11, 2022 that may be closed by this pull request
Create table from file #145
Closed
@github-actions
Copy link

github-actions bot commented Nov 11, 2022 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ JSON eslint-plugin-jsonc 1 0 0 1.54s
✅ JSON jsonlint 1 0 0.29s
✅ JSON prettier 1 0 0 0.73s
✅ JSON v8r 1 0 2.15s
✅ PYTHON bandit 2 0 0.66s
✅ PYTHON black 2 0 0 0.82s
✅ PYTHON flake8 2 0 0.46s
✅ PYTHON isort 2 0 0 0.35s
✅ PYTHON mypy 2 0 2.65s
✅ PYTHON pylint 2 0 1.76s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@dorianheidorn dorianheidorn self-requested a review November 11, 2022 14:41
dorianheidorn
dorianheidorn reviewed Nov 11, 2022
View reviewed changes
Copy link
Contributor

@dorianheidorn dorianheidorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ich habe soweit keine Fehler oder unstimmigkeiten gefunden!

@WinPlay02 WinPlay02 enabled auto-merge (squash) November 11, 2022 14:47
dorianheidorn
dorianheidorn previously requested changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@dorianheidorn dorianheidorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bitte noch Leerzeile in test_table.py nach dem ersten Import hinzufügen. In den anderen Pull-requests ist diese Formatierung auch so.

GideonKoenig
GideonKoenig previously approved these changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@GideonKoenig GideonKoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@lars-reimann lars-reimann merged commit 1697690 into main Nov 16, 2022
@lars-reimann lars-reimann deleted the 145-create-table-from-file branch November 16, 2022 11:39
Gerhardsa0 pushed a commit that referenced this pull request Dec 9, 2022
@WinPlay02 @lars-reimann @Gerhardsa0
feat: Create table from file: read_csv and read_json (#164)
e99baa1 
Closes #145.

### Summary of Changes

Added functions: read_csv and read_json
Added Tests: valid and invalid inputs

Co-authored-by: WinPlay02 <WinPlay02@users.noreply.github.com>
Co-authored-by: Lars Reimann <mail@larsreimann.com>
Co-authored-by: lars-reimann <lars-reimann@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lars-reimann lars-reimann lars-reimann approved these changes

@GideonKoenig GideonKoenig GideonKoenig left review comments

@dorianheidorn dorianheidorn Awaiting requested review from dorianheidorn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create table from file
4 participants
@WinPlay02 @lars-reimann @dorianheidorn @GideonKoenig