Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that methods of Table update the schema properly #124

Closed
lars-reimann opened this issue Mar 30, 2023 · 3 comments · Fixed by #305
Closed

Check that methods of Table update the schema properly #124

lars-reimann opened this issue Mar 30, 2023 · 3 comments · Fixed by #305
Assignees
@alex-senger @daniaHu
Labels
released Included in a release testing 🧪 Additional automated tests

Comments

@lars-reimann
Copy link
Member

At best, the existing tests of the methods that return a new Table check whether this new Table has the correct data. We must also ensure that its schema is correct. This needs more tests.
@lars-reimann lars-reimann added the testing 🧪 Additional automated tests label Mar 30, 2023
@lars-reimann
Copy link
Member Author

Should be done after #98.

@alex-senger alex-senger linked a pull request May 12, 2023 that will close this issue
test: Add Schema checks to Table tests #305
Merged
@alex-senger alex-senger mentioned this issue May 12, 2023
Merged
@zzril
Copy link
Contributor

zzril commented May 19, 2023 •
edited
Loading

There should be a dedicated test for testing that the schema has been set up properly for a new Table.

This could be done in a new test, or inside of tests/safeds/data/tabular/containers/table/test_column_names.py (which currently seems to be responsible for testing the Table constructor method).

Edit: Nvm, this is already by test_should_infer_the_schema in test_init.py.

alex-senger added a commit that referenced this issue May 26, 2023
@alex-senger @daniaHu
@megalinter-bot @zzril @Marsmaennchen221
test: Add Schema checks to Table tests (#305)
ca22ed1 
Closes #124.

### Summary of Changes

Add `Schema` checks to `Table` tests

<!-- Please provide a summary of changes in this pull request, ensuring
all changes are explained. -->

---------

Co-authored-by: daniaHu <129186516+daniaHu@users.noreply.github.com>
Co-authored-by: megalinter-bot <129584137+megalinter-bot@users.noreply.github.com>
Co-authored-by: Severin Paul Höfer <84280965+zzril@users.noreply.github.com>
Co-authored-by: Marsmaennchen221 <47296670+Marsmaennchen221@users.noreply.github.com>
@zzril zzril mentioned this issue May 29, 2023
Merged
@lars-reimann
Copy link
Member Author

🎉 This issue has been resolved in version 0.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alex-senger alex-senger

@daniaHu daniaHu

Labels
released Included in a release testing 🧪 Additional automated tests
Projects
Library
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Add Schema checks to Table tests Safe-DS/Library
4 participants
@lars-reimann @zzril @alex-senger @daniaHu